[NUI] Fix Svace issue not to do unnecessary null check in DefaultBorder
authorJaehyun Cho <jae_hyun.cho@samsung.com>
Thu, 21 Apr 2022 02:48:20 +0000 (11:48 +0900)
committerJaehyun Cho <jaehyun0cho@gmail.com>
Thu, 21 Apr 2022 10:39:37 +0000 (19:39 +0900)
Svace issue occurs because null check of BorderWindow is done after
BorderWindow is accessed in DefaultBorder.Dispose().

When close button in DefaultBorder is clicked, BorderWindow is disposed.
When BorderWindow is disposed, DisposeBorder() is called.
In DisposeBorder(), DefaultBorder is disposed.
When DefaultBorder is disposed, BorderWindow is under disposed but
BorderWindow is not set to be null yet.
Therefore, it is not necessary to do null check of BorderWindow in
DefaultBorder.Dispose() to resolve the Svace issue.

src/Tizen.NUI/src/public/Window/DefaultBorder.cs

index eed66b4..b3004ed 100755 (executable)
@@ -673,10 +673,9 @@ namespace Tizen.NUI
             if (disposing)
             {
                 ClearWindowGesture();
-                if (BorderWindow != null)
-                {
-                    BorderWindow.InterceptTouchEvent -= OnWinInterceptedTouch;
-                }
+
+                BorderWindow.InterceptTouchEvent -= OnWinInterceptedTouch;
+
                 borderPanGestureDetector?.Dispose();
                 borderPinchGestureDetector?.Dispose();
                 backgroundColor?.Dispose();