mm: /proc/sys/vm/stat_refresh stop checking monotonic numa stats
authorHugh Dickins <hughd@google.com>
Wed, 5 May 2021 01:38:00 +0000 (18:38 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 5 May 2021 18:27:25 +0000 (11:27 -0700)
All of the VM NUMA stats are event counts, incremented never
decremented: it is not very useful for vmstat_refresh() to check them
throughout their first aeon, then warn on them throughout their next.

Link: https://lkml.kernel.org/r/alpine.LSU.2.11.2102251514110.13363@eggly.anvils
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Roman Gushchin <guro@fb.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/vmstat.c

index 5437a78..06cd78d 100644 (file)
@@ -1872,15 +1872,6 @@ int vmstat_refresh(struct ctl_table *table, int write,
                                __func__, zone_stat_name(i), val);
                }
        }
-#ifdef CONFIG_NUMA
-       for (i = 0; i < NR_VM_NUMA_STAT_ITEMS; i++) {
-               val = atomic_long_read(&vm_numa_stat[i]);
-               if (val < 0) {
-                       pr_warn("%s: %s %ld\n",
-                               __func__, numa_stat_name(i), val);
-               }
-       }
-#endif
        for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) {
                /*
                 * Skip checking stats known to go negative occasionally.