v4l: add a fixme for broken code, that someone who has a v4l tuner device should fix
authorStefan Kost <ensonic@users.sf.net>
Thu, 5 Mar 2009 08:51:25 +0000 (10:51 +0200)
committerStefan Kost <ensonic@users.sf.net>
Thu, 5 Mar 2009 08:51:25 +0000 (10:51 +0200)
sys/v4l/v4l_calls.c

index 0baf5ade1cca0db607fd3c623f2c60fb58f0b3bf..0a012659637644db223e85b7bb5a0ef38be68d4e 100644 (file)
@@ -330,6 +330,11 @@ gst_v4l_get_chan_names (GstV4lElement * v4lelement)
             continue;           /* not this one */
           }
         }
+        /* FIXME: in the case of n >= vchan.tuners the code below accesses
+         * uninitialised fields in vtun
+         * Not sure if the codeblock below should go into the else above, but
+         * then setting vtun.tuner=0 is a bit pointless.
+         */
         v4lchannel->tuner = n;
         channel->flags |= GST_TUNER_CHANNEL_FREQUENCY;
         channel->freq_multiplicator =