ASoC: apple: mca: Fix final status read on SERDES reset
authorMartin Povišer <povik+lin@cutebit.org>
Fri, 24 Feb 2023 15:33:00 +0000 (16:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 11 Mar 2023 12:55:30 +0000 (13:55 +0100)
[ Upstream commit aaf5f0d76b6e1870e3674408de2b13a92a4d4059 ]

From within the early trigger we are doing a reset of the SERDES unit,
but the final status read is on a bad address. Add the missing SERDES
unit offset in calculation of the address.

Fixes: 3df5d0d97289 ("ASoC: apple: mca: Start new platform driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
Link: https://lore.kernel.org/r/20230224153302.45365-1-povik+lin@cutebit.org
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/apple/mca.c

index 24381c4..9cceeb2 100644 (file)
@@ -210,7 +210,7 @@ static void mca_fe_early_trigger(struct snd_pcm_substream *substream, int cmd,
                           SERDES_CONF_SOME_RST);
                readl_relaxed(cl->base + serdes_conf);
                mca_modify(cl, serdes_conf, SERDES_STATUS_RST, 0);
-               WARN_ON(readl_relaxed(cl->base + REG_SERDES_STATUS) &
+               WARN_ON(readl_relaxed(cl->base + serdes_unit + REG_SERDES_STATUS) &
                        SERDES_STATUS_RST);
                break;
        default: