sata: call device_probe() after scanning
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Tue, 8 Mar 2022 11:36:43 +0000 (20:36 +0900)
committerHeinrich Schuchardt <heinrich.schuchardt@canonical.com>
Sat, 9 Apr 2022 19:06:31 +0000 (21:06 +0200)
Every time a sata bus/port is scanned and a new device is detected,
we want to call device_probe() as it will give us a chance to run
additional post-processings for some purposes.

In particular, support for creating partitions on a device will be added.

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Reviewed-by: Simon Glass <sjg@chromium.org>
drivers/ata/dwc_ahsata.c
drivers/ata/fsl_sata.c
drivers/ata/sata_mv.c
drivers/ata/sata_sil.c

index 6d42548..d9fd850 100644 (file)
@@ -1026,6 +1026,11 @@ int dwc_ahsata_scan(struct udevice *dev)
                return ret;
        }
 
+       ret = blk_probe_or_unbind(dev);
+       if (ret < 0)
+               /* TODO: undo create */
+               return ret;
+
        return 0;
 }
 
index e44db0a..d1bab93 100644 (file)
@@ -982,6 +982,17 @@ static int fsl_ata_probe(struct udevice *dev)
                        failed_number++;
                        continue;
                }
+
+               ret = device_probe(dev);
+               if (ret < 0) {
+                       debug("Probing %s failed (%d)\n", dev->name, ret);
+                       ret = fsl_unbind_device(blk);
+                       if (ret)
+                               return ret;
+
+                       failed_number++;
+                       continue;
+               }
        }
 
        if (failed_number == nr_ports)
index 003222d..a187796 100644 (file)
@@ -1099,6 +1099,11 @@ static int sata_mv_probe(struct udevice *dev)
                        continue;
                }
 
+               ret = blk_probe_or_unbind(dev);
+               if (ret < 0)
+                       /* TODO: undo create */
+                       continue;
+
                /* If we got here, the current SATA port was probed
                 * successfully, so set the probe status to successful.
                 */
index a4f0dae..b213eba 100644 (file)
@@ -753,6 +753,18 @@ static int sil_pci_probe(struct udevice *dev)
                        failed_number++;
                        continue;
                }
+
+               ret = device_probe(dev);
+               if (ret < 0) {
+                       debug("Probing %s failed (%d)\n", dev->name, ret);
+                       ret = sil_unbind_device(blk);
+                       device_unbind(dev);
+                       if (ret)
+                               return ret;
+
+                       failed_number++;
+                       continue;
+               }
        }
 
        if (failed_number == sata_info.maxport)