crypto: atmel-{aes,tdes} - Do not save IV for ECB mode

ECB mode does not use IV.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index 262079a..f25dd0e 100644 (file)
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -515,6 +515,9 @@ static void atmel_aes_set_iv_as_last_ciphertext_block(struct atmel_aes_dev *dd)
 
 static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err)
 {
+       struct skcipher_request *req = skcipher_request_cast(dd->areq);
+       struct atmel_aes_reqctx *rctx = skcipher_request_ctx(req);
+
 #if IS_ENABLED(CONFIG_CRYPTO_DEV_ATMEL_AUTHENC)
        if (dd->ctx->is_aead)
                atmel_aes_authenc_complete(dd, err);
@@ -523,7 +526,8 @@ static inline int atmel_aes_complete(struct atmel_aes_dev *dd, int err)
        clk_disable(dd->iclk);
        dd->flags &= ~AES_FLAGS_BUSY;
 
-       if (!dd->ctx->is_aead)
+       if (!dd->ctx->is_aead &&
+           (rctx->mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB)
                atmel_aes_set_iv_as_last_ciphertext_block(dd);
 
        if (dd->is_async)
@@ -1130,7 +1134,8 @@ static int atmel_aes_crypt(struct skcipher_request *req, unsigned long mode)
        rctx = skcipher_request_ctx(req);
        rctx->mode = mode;
 
-       if (!(mode & AES_FLAGS_ENCRYPT) && (req->src == req->dst)) {
+       if ((mode & AES_FLAGS_OPMODE_MASK) != AES_FLAGS_ECB &&
+           !(mode & AES_FLAGS_ENCRYPT) && req->src == req->dst) {
                unsigned int ivsize = crypto_skcipher_ivsize(skcipher);
 
                if (req->cryptlen >= ivsize)

diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 8a067c1..cf53b57 100644 (file)
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -593,12 +593,14 @@ atmel_tdes_set_iv_as_last_ciphertext_block(struct atmel_tdes_dev *dd)
 static void atmel_tdes_finish_req(struct atmel_tdes_dev *dd, int err)
 {
        struct skcipher_request *req = dd->req;
+       struct atmel_tdes_reqctx *rctx = skcipher_request_ctx(req);
 
        clk_disable_unprepare(dd->iclk);
 
        dd->flags &= ~TDES_FLAGS_BUSY;
 
-       atmel_tdes_set_iv_as_last_ciphertext_block(dd);
+       if ((rctx->mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB)
+               atmel_tdes_set_iv_as_last_ciphertext_block(dd);
 
        req->base.complete(&req->base, err);
 }
@@ -728,7 +730,8 @@ static int atmel_tdes_crypt(struct skcipher_request *req, unsigned long mode)
 
        rctx->mode = mode;
 
-       if (!(mode & TDES_FLAGS_ENCRYPT) && req->src == req->dst) {
+       if ((mode & TDES_FLAGS_OPMODE_MASK) != TDES_FLAGS_ECB &&
+           !(mode & TDES_FLAGS_ENCRYPT) && req->src == req->dst) {
                unsigned int ivsize = crypto_skcipher_ivsize(skcipher);
 
                if (req->cryptlen >= ivsize)