common/ptid.h: Mention that process_stratum targets should prefer ptid.lwp.

It's best that we standardize on process_stratum targets using the
ptid.lwp field to store thread ids.  The idea being leave the ptid.tid
field free for any thread_stratum target that might want to sit on
top.  This patch adds a comment in that direction to struct ptid's
definition.

gdb/
2014-02-19  Pedro Alves  <palves@redhat.com>

	* common/ptid.h (struct ptid): Mention that process_stratum
	targets should prefer ptid.lwp.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 122288d..f8779b0 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,10 @@
 2014-02-19  Pedro Alves  <palves@redhat.com>
 
+       * common/ptid.h (struct ptid): Mention that process_stratum
+       targets should prefer ptid.lwp.
+
+2014-02-19  Pedro Alves  <palves@redhat.com>
+
        * remote.c (remote_thread_alive, write_ptid, read_ptid)
        (read_ptid, remote_newthread_step, remote_threads_extra_info)
        (remote_get_ada_task_ptid, append_resumption, remote_stop_ns)

diff --git a/gdb/common/ptid.h b/gdb/common/ptid.h
index 362882d..cc1825e 100644 (file)
--- a/gdb/common/ptid.h
+++ b/gdb/common/ptid.h
@@ -25,7 +25,12 @@
    consists of the process id (pid), lightweight process id (lwp) and
    thread id (tid).  When manipulating ptids, the constructors,
    accessors, and predicates declared in this file should be used.  Do
-   NOT access the struct ptid members directly.  */
+   NOT access the struct ptid members directly.
+
+   process_stratum targets that handle threading themselves should
+   prefer using the ptid.lwp field, leaving the ptid.tid field for any
+   thread_stratum target that might want to sit on top.
+*/
 
 struct ptid
 {