[media] xilinx-vipp: remove unnecessary of_node_put
authorFranck Jullien <franck.jullien@odyssee-systemes.fr>
Tue, 22 Mar 2016 10:43:58 +0000 (07:43 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Sat, 7 May 2016 14:45:38 +0000 (11:45 -0300)
of_graph_get_next_endpoint(node, ep) decrements refcount on
ep. When next==NULL we break and refcount on ep is decremented
again.

Signed-off-by: Franck Jullien <franck.jullien@odyssee-systemes.fr>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/xilinx/xilinx-vipp.c

index e795a45..feb3b2f 100644 (file)
@@ -351,19 +351,15 @@ static int xvip_graph_parse_one(struct xvip_composite_device *xdev,
        struct xvip_graph_entity *entity;
        struct device_node *remote;
        struct device_node *ep = NULL;
-       struct device_node *next;
        int ret = 0;
 
        dev_dbg(xdev->dev, "parsing node %s\n", node->full_name);
 
        while (1) {
-               next = of_graph_get_next_endpoint(node, ep);
-               if (next == NULL)
+               ep = of_graph_get_next_endpoint(node, ep);
+               if (ep == NULL)
                        break;
 
-               of_node_put(ep);
-               ep = next;
-
                dev_dbg(xdev->dev, "handling endpoint %s\n", ep->full_name);
 
                remote = of_graph_get_remote_port_parent(ep);