Bluetooth: hci_qca: Add support for controller debug logs.
authorBalakrishna Godavarthi <bgodavar@codeaurora.org>
Tue, 16 Oct 2018 14:21:35 +0000 (19:51 +0530)
committerMarcel Holtmann <marcel@holtmann.org>
Thu, 18 Oct 2018 07:55:16 +0000 (09:55 +0200)
This patch will prevent error messages splashing on console.

[   78.426697] Bluetooth: hci_core.c:hci_acldata_packet() hci0: ACL packet for unknown connection handle 3804
[   78.436682] Bluetooth: hci_core.c:hci_acldata_packet() hci0: ACL packet for unknown connection handle 3804
[   78.446639] Bluetooth: hci_core.c:hci_acldata_packet() hci0: ACL packet for unknown connection handle 3804
[   78.456596] Bluetooth: hci_core.c:hci_acldata_packet() hci0: ACL packet for unknown connection handle 3804

QCA wcn3990 will send the debug logs in the form of ACL packets.
While decoding packet in qca_recv(), marking the received debug log
packet as diagnostic packet.

Signed-off-by: Harish Bandi <c-hbandi@codeaurora.org>
Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
drivers/bluetooth/hci_qca.c

index 9f1392fc71054dadce37298aa648bcf1ae7b6ed3..f036c8f98ea3376317e0256a83cec44a3a4d0cc2 100644 (file)
@@ -40,6 +40,7 @@
 #include <linux/platform_device.h>
 #include <linux/regulator/consumer.h>
 #include <linux/serdev.h>
+#include <asm/unaligned.h>
 
 #include <net/bluetooth/bluetooth.h>
 #include <net/bluetooth/hci_core.h>
@@ -63,6 +64,9 @@
 /* susclk rate */
 #define SUSCLK_RATE_32KHZ      32768
 
+/* Controller debug log header */
+#define QCA_DEBUG_HANDLE       0x2EDC
+
 /* HCI_IBS transmit side sleep protocol states */
 enum tx_ibs_states {
        HCI_IBS_TX_ASLEEP,
@@ -849,6 +853,19 @@ static int qca_ibs_wake_ack(struct hci_dev *hdev, struct sk_buff *skb)
        return 0;
 }
 
+static int qca_recv_acl_data(struct hci_dev *hdev, struct sk_buff *skb)
+{
+       /* We receive debug logs from chip as an ACL packets.
+        * Instead of sending the data to ACL to decode the
+        * received data, we are pushing them to the above layers
+        * as a diagnostic packet.
+        */
+       if (get_unaligned_le16(skb->data) == QCA_DEBUG_HANDLE)
+               return hci_recv_diag(hdev, skb);
+
+       return hci_recv_frame(hdev, skb);
+}
+
 #define QCA_IBS_SLEEP_IND_EVENT \
        .type = HCI_IBS_SLEEP_IND, \
        .hlen = 0, \
@@ -871,7 +888,7 @@ static int qca_ibs_wake_ack(struct hci_dev *hdev, struct sk_buff *skb)
        .maxlen = HCI_MAX_IBS_SIZE
 
 static const struct h4_recv_pkt qca_recv_pkts[] = {
-       { H4_RECV_ACL,             .recv = hci_recv_frame    },
+       { H4_RECV_ACL,             .recv = qca_recv_acl_data },
        { H4_RECV_SCO,             .recv = hci_recv_frame    },
        { H4_RECV_EVENT,           .recv = hci_recv_frame    },
        { QCA_IBS_WAKE_IND_EVENT,  .recv = qca_ibs_wake_ind  },