brcmfmac: avoid firmware command in brcmf_netdev_open() when bus is down
authorArend van Spriel <arend.vanspriel@broadcom.com>
Thu, 11 Jul 2019 09:05:08 +0000 (11:05 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Wed, 24 Jul 2019 11:51:23 +0000 (14:51 +0300)
No point in sending a firmware command when bus is down so make it
conditional checking the state.

Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
Reviewed-by: Franky Lin <franky.lin@broadcom.com>
Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c

index 80d54d2..705b8cc 100644 (file)
@@ -579,7 +579,8 @@ static int brcmf_netdev_stop(struct net_device *ndev)
 
        brcmf_cfg80211_down(ndev);
 
-       brcmf_fil_iovar_data_set(ifp, "arp_hostip_clear", NULL, 0);
+       if (ifp->drvr->bus_if->state == BRCMF_BUS_UP)
+               brcmf_fil_iovar_data_set(ifp, "arp_hostip_clear", NULL, 0);
 
        brcmf_net_setcarrier(ifp, false);