iwlwifi: mei: Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 16 Feb 2022 19:50:30 +0000 (13:50 -0600)
committerKalle Valo <kvalo@kernel.org>
Wed, 6 Apr 2022 07:19:08 +0000 (10:19 +0300)
There is a regular need in the kernel to provide a way to declare
having a dynamically sized set of trailing elements in a structure.
Kernel code should always use “flexible array members”[1] for these
cases. The older style of one-element or zero-length arrays should
no longer be used[2].

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays

Link: https://github.com/KSPP/linux/issues/78
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220216195030.GA904170@embeddedor
drivers/net/wireless/intel/iwlwifi/mei/sap.h

index 11e3009..be1456d 100644 (file)
@@ -298,7 +298,7 @@ struct iwl_sap_hdr {
        __le16 type;
        __le16 len;
        __le32 seq_num;
-       u8 payload[0];
+       u8 payload[];
 };
 
 /**