net: caif: replace BUG_ON with recovery code
authorAditya Pakki <pakki001@umn.edu>
Sun, 15 Dec 2019 17:51:30 +0000 (11:51 -0600)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Dec 2019 00:29:05 +0000 (16:29 -0800)
In caif_xmit, there is a crash if the ptr dev is NULL. However, by
returning the error to the callers, the error can be handled. The
patch fixes this issue.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/caif/caif_serial.c

index bd40b11..d737ceb 100644 (file)
@@ -270,7 +270,9 @@ static int caif_xmit(struct sk_buff *skb, struct net_device *dev)
 {
        struct ser_device *ser;
 
-       BUG_ON(dev == NULL);
+       if (WARN_ON(!dev))
+               return -EINVAL;
+
        ser = netdev_priv(dev);
 
        /* Send flow off once, on high water mark */