netns: fdb: allow unprivileged users to add/del fdb entries
authorGao feng <gaofeng@cn.fujitsu.com>
Thu, 31 Jan 2013 16:30:57 +0000 (16:30 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Feb 2013 18:12:16 +0000 (13:12 -0500)
Right now,only ixgdb,macvlan,vxlan and bridge implement
fdb_add/fdb_del operations.

these operations only operate the private data of net
device. So allowing the unprivileged users who creates
the userns and netns to add/del fdb entries will do no
harm to other netns.

Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index 9a419b0..c1e4db6 100644 (file)
@@ -2058,9 +2058,6 @@ static int rtnl_fdb_add(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
        u8 *addr;
        int err;
 
-       if (!capable(CAP_NET_ADMIN))
-               return -EPERM;
-
        err = nlmsg_parse(nlh, sizeof(*ndm), tb, NDA_MAX, NULL);
        if (err < 0)
                return err;
@@ -2127,9 +2124,6 @@ static int rtnl_fdb_del(struct sk_buff *skb, struct nlmsghdr *nlh, void *arg)
        int err = -EINVAL;
        __u8 *addr;
 
-       if (!capable(CAP_NET_ADMIN))
-               return -EPERM;
-
        if (nlmsg_len(nlh) < sizeof(*ndm))
                return -EINVAL;