webrtcbin: Avoid access of freed memory

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2256>

diff --git a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
index c847c09..a1c7fa0 100644 (file)
--- a/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
+++ b/subprojects/gst-plugins-bad/ext/webrtc/gstwebrtcbin.c
@@ -1886,7 +1886,6 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
       caps = _query_pad_caps (webrtc, rtp_trans, pad, filter, error);
     }
-    gst_object_unref (pad);
 
     if (*error)
       goto out;
@@ -1940,6 +1939,8 @@ _find_codec_preferences (GstWebRTCBin * webrtc,
 
 out:
 
+  if (pad)
+    gst_object_unref (pad);
   if (codec_preferences)
     gst_caps_unref (codec_preferences);