drm/i915: Fix i915_driver_init_mmio error path
authorMichal Wajdeczko <michal.wajdeczko@intel.com>
Thu, 11 Oct 2018 13:00:07 +0000 (13:00 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Thu, 11 Oct 2018 20:06:42 +0000 (21:06 +0100)
In case of the error we missed to call i915_mmio_cleanup
that matches earlier call to i915_mmio_setup.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20181011130008.24640-1-michal.wajdeczko@intel.com
drivers/gpu/drm/i915/i915_drv.c

index 1930234..baac35f 100644 (file)
@@ -1030,6 +1030,7 @@ static int i915_driver_init_mmio(struct drm_i915_private *dev_priv)
 
 err_uncore:
        intel_uncore_fini(dev_priv);
+       i915_mmio_cleanup(dev_priv);
 err_bridge:
        pci_dev_put(dev_priv->bridge_dev);