gst-libs/gst/cdda/gstcddabasesrc.c: Remove erroneous gst_buffer_ref().
authorEdward Hervey <bilboed@bilboed.com>
Fri, 12 Dec 2008 19:41:28 +0000 (19:41 +0000)
committerEdward Hervey <bilboed@bilboed.com>
Fri, 12 Dec 2008 19:41:28 +0000 (19:41 +0000)
Original commit message from CVS:
* gst-libs/gst/cdda/gstcddabasesrc.c:
(gst_cdda_base_src_handle_event):
Remove erroneous gst_buffer_ref().
* tests/check/libs/rtp.c: (GST_START_TEST):
Don't forget to unref the buffer once you're done with it.

ChangeLog
common
gst-libs/gst/cdda/gstcddabasesrc.c
tests/check/libs/rtp.c

index f342bbf..4987850 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-12-12  Edward Hervey  <edward.hervey@collabora.co.uk>
+
+       * gst-libs/gst/cdda/gstcddabasesrc.c:
+       (gst_cdda_base_src_handle_event):
+       Remove erroneous gst_buffer_ref().
+       * tests/check/libs/rtp.c: (GST_START_TEST):
+       Don't forget to unref the buffer once you're done with it.
+
 2008-12-12  Stefan Kost  <ensonic@users.sf.net>
 
        * gst/playback/gstplaybin.c:
diff --git a/common b/common
index f811de6..1c24dce 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit f811de62e9cea6e3d4174a0b172733b2c7952c1d
+Subproject commit 1c24dce4e32f0a725ebd1b8ba2cd48d373818f75
index 6e2999b..910d83e 100644 (file)
@@ -877,7 +877,6 @@ gst_cdda_base_src_handle_event (GstBaseSrc * basesrc, GstEvent * event)
     }
     default:{
       GST_LOG_OBJECT (src, "let base class handle event");
-      event = gst_event_ref (event);
       ret = GST_BASE_SRC_CLASS (parent_class)->event (basesrc, event);
       break;
     }
index 3461800..bfc33ae 100644 (file)
@@ -355,6 +355,7 @@ GST_START_TEST (test_rtcp_buffer)
   /* close and validate */
   gst_rtcp_buffer_end (buf);
   fail_unless (gst_rtcp_buffer_validate (buf) == TRUE);
+  gst_buffer_unref (buf);
 }
 
 GST_END_TEST;