gst-libs/gst/cdda/gstcddabasesrc.c: Remove erroneous gst_buffer_ref().

Original commit message from CVS:
* gst-libs/gst/cdda/gstcddabasesrc.c:
(gst_cdda_base_src_handle_event):
Remove erroneous gst_buffer_ref().
* tests/check/libs/rtp.c: (GST_START_TEST):
Don't forget to unref the buffer once you're done with it.

diff --git a/ChangeLog b/ChangeLog
index f342bbf4874cf4d6b9a4c2f4c23a4ba82e368abe..4987850eacfbea2b0b477086303d2a308ecaaf96 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2008-12-12  Edward Hervey  <edward.hervey@collabora.co.uk>
+
+       * gst-libs/gst/cdda/gstcddabasesrc.c:
+       (gst_cdda_base_src_handle_event):
+       Remove erroneous gst_buffer_ref().
+       * tests/check/libs/rtp.c: (GST_START_TEST):
+       Don't forget to unref the buffer once you're done with it.
+
 2008-12-12  Stefan Kost  <ensonic@users.sf.net>
 
        * gst/playback/gstplaybin.c:

diff --git a/common b/common
index f811de62e9cea6e3d4174a0b172733b2c7952c1d..1c24dce4e32f0a725ebd1b8ba2cd48d373818f75 160000 (submodule)
--- a/common
+++ b/common
@@ -1 +1 @@
-Subproject commit f811de62e9cea6e3d4174a0b172733b2c7952c1d
+Subproject commit 1c24dce4e32f0a725ebd1b8ba2cd48d373818f75

diff --git a/gst-libs/gst/cdda/gstcddabasesrc.c b/gst-libs/gst/cdda/gstcddabasesrc.c
index 6e2999b0eaafd2f236012048ea6a45a2d7efd0b4..910d83e5251d4c47aa2af8e0e459a4d2d70b13a5 100644 (file)
--- a/gst-libs/gst/cdda/gstcddabasesrc.c
+++ b/gst-libs/gst/cdda/gstcddabasesrc.c
@@ -877,7 +877,6 @@ gst_cdda_base_src_handle_event (GstBaseSrc * basesrc, GstEvent * event)
     }
     default:{
       GST_LOG_OBJECT (src, "let base class handle event");
-      event = gst_event_ref (event);
       ret = GST_BASE_SRC_CLASS (parent_class)->event (basesrc, event);
       break;
     }

diff --git a/tests/check/libs/rtp.c b/tests/check/libs/rtp.c
index 346180086bc29b37fa8a070ac723a171f74949b7..bfc33ae495bf1029b6c1c4234281faf48e0fc32f 100644 (file)
--- a/tests/check/libs/rtp.c
+++ b/tests/check/libs/rtp.c
@@ -355,6 +355,7 @@ GST_START_TEST (test_rtcp_buffer)
   /* close and validate */
   gst_rtcp_buffer_end (buf);
   fail_unless (gst_rtcp_buffer_validate (buf) == TRUE);
+  gst_buffer_unref (buf);
 }
 
 GST_END_TEST;