w1: w1-gpio: Make GPIO an output for strong pullup
authorPhil Elwell <phil@raspberrypi.org>
Wed, 12 Jun 2019 16:15:05 +0000 (17:15 +0100)
committerDom Cobley <popcornmix@gmail.com>
Mon, 21 Mar 2022 16:03:54 +0000 (16:03 +0000)
The logic to drive the data line high to implement a strong pullup
assumed that the pin was already an output - setting a value does
not change an input.

See: https://github.com/raspberrypi/firmware/issues/1143

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
drivers/w1/masters/w1-gpio.c

index d4632aa..4832cd8 100644 (file)
@@ -30,7 +30,7 @@ static u8 w1_gpio_set_pullup(void *data, int delay)
                         * This will OVERRIDE open drain emulation and force-pull
                         * the line high for some time.
                         */
-                       gpiod_set_raw_value(pdata->gpiod, 1);
+                       gpiod_direction_output_raw(pdata->gpiod, 1);
                        msleep(pdata->pullup_duration);
                        /*
                         * This will simply set the line as input since we are doing