Input: elan_i2c - check if device is there before really probing
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 19 Dec 2014 20:57:49 +0000 (12:57 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 12 May 2017 00:41:53 +0000 (17:41 -0700)
Before trying to properly initialize the touchpad and generate bunch of
errors, let's first see it there is anything at the given address. If we
get error, fail silently with -ENXIO.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/elan_i2c_core.c

index d5ab9dd..551ad29 100644 (file)
@@ -1077,6 +1077,13 @@ static int elan_probe(struct i2c_client *client,
                return error;
        }
 
+       /* Make sure there is something at this address */
+       error = i2c_smbus_read_byte(client);
+       if (error < 0) {
+               dev_dbg(&client->dev, "nothing at this address: %d\n", error);
+               return -ENXIO;
+       }
+
        /* Initialize the touchpad. */
        error = elan_initialize(data);
        if (error)