kunit: drop unused intermediate macros for ptr inequality checks
authorDaniel Latypov <dlatypov@google.com>
Tue, 18 Jan 2022 22:35:03 +0000 (14:35 -0800)
committerShuah Khan <skhan@linuxfoundation.org>
Tue, 25 Jan 2022 20:04:31 +0000 (13:04 -0700)
We have the intermediate macros for KUNIT_EXPECT_PTR_GT() and friends,
but these macros don't exist.

I can see niche usecases for these macros existing, but since we've been
fine without them for so long, let's drop this dead code.

Users can instead cast the pointers and use the other GT/LT macros.

Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: David Gow <davidgow@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
include/kunit/test.h

index b032dd6..c021945 100644 (file)
@@ -1044,21 +1044,6 @@ do {                                                                            \
                                    fmt,                                       \
                                    ##__VA_ARGS__)
 
-#define KUNIT_BINARY_PTR_LT_MSG_ASSERTION(test,                                       \
-                                         assert_type,                         \
-                                         left,                                \
-                                         right,                               \
-                                         fmt,                                 \
-                                         ...)                                 \
-       KUNIT_BASE_LT_MSG_ASSERTION(test,                                      \
-                                   kunit_binary_ptr_assert,                   \
-                                   KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT,       \
-                                   assert_type,                               \
-                                   left,                                      \
-                                   right,                                     \
-                                   fmt,                                       \
-                                   ##__VA_ARGS__)
-
 #define KUNIT_BINARY_LE_MSG_ASSERTION(test, assert_type, left, right, fmt, ...)\
        KUNIT_BASE_LE_MSG_ASSERTION(test,                                      \
                                    kunit_binary_assert,                       \
@@ -1069,21 +1054,6 @@ do {                                                                            \
                                    fmt,                                       \
                                    ##__VA_ARGS__)
 
-#define KUNIT_BINARY_PTR_LE_MSG_ASSERTION(test,                                       \
-                                         assert_type,                         \
-                                         left,                                \
-                                         right,                               \
-                                         fmt,                                 \
-                                         ...)                                 \
-       KUNIT_BASE_LE_MSG_ASSERTION(test,                                      \
-                                   kunit_binary_ptr_assert,                   \
-                                   KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT,       \
-                                   assert_type,                               \
-                                   left,                                      \
-                                   right,                                     \
-                                   fmt,                                       \
-                                   ##__VA_ARGS__)
-
 #define KUNIT_BINARY_GT_MSG_ASSERTION(test, assert_type, left, right, fmt, ...)\
        KUNIT_BASE_GT_MSG_ASSERTION(test,                                      \
                                    kunit_binary_assert,                       \
@@ -1094,21 +1064,6 @@ do {                                                                            \
                                    fmt,                                       \
                                    ##__VA_ARGS__)
 
-#define KUNIT_BINARY_PTR_GT_MSG_ASSERTION(test,                                       \
-                                         assert_type,                         \
-                                         left,                                \
-                                         right,                               \
-                                         fmt,                                 \
-                                         ...)                                 \
-       KUNIT_BASE_GT_MSG_ASSERTION(test,                                      \
-                                   kunit_binary_ptr_assert,                   \
-                                   KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT,       \
-                                   assert_type,                               \
-                                   left,                                      \
-                                   right,                                     \
-                                   fmt,                                       \
-                                   ##__VA_ARGS__)
-
 #define KUNIT_BINARY_GE_MSG_ASSERTION(test, assert_type, left, right, fmt, ...)\
        KUNIT_BASE_GE_MSG_ASSERTION(test,                                      \
                                    kunit_binary_assert,                       \
@@ -1119,21 +1074,6 @@ do {                                                                            \
                                    fmt,                                       \
                                    ##__VA_ARGS__)
 
-#define KUNIT_BINARY_PTR_GE_MSG_ASSERTION(test,                                       \
-                                         assert_type,                         \
-                                         left,                                \
-                                         right,                               \
-                                         fmt,                                 \
-                                         ...)                                 \
-       KUNIT_BASE_GE_MSG_ASSERTION(test,                                      \
-                                   kunit_binary_ptr_assert,                   \
-                                   KUNIT_INIT_BINARY_PTR_ASSERT_STRUCT,       \
-                                   assert_type,                               \
-                                   left,                                      \
-                                   right,                                     \
-                                   fmt,                                       \
-                                   ##__VA_ARGS__)
-
 #define KUNIT_BINARY_STR_ASSERTION(test,                                      \
                                   assert_type,                                \
                                   left,                                       \