Reset pointer to 0 after freeing
authorLars Knoll <lars.knoll@nokia.com>
Mon, 30 Apr 2012 09:56:45 +0000 (11:56 +0200)
committerQt by Nokia <qt-info@nokia.com>
Tue, 1 May 2012 05:10:34 +0000 (07:10 +0200)
set m_textureResource to 0 after freeing it, to
ensure we allocate a new one two lines below before
using it again 5 lines below.

Change-Id: Ib9c4de94aefed91f15d0fab0cd3c774a64f2f891
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
src/gui/opengl/qopengltextureglyphcache.cpp
src/opengl/gl2paintengineex/qtextureglyphcache_gl.cpp

index b37e8fb..790b92a 100644 (file)
@@ -106,8 +106,10 @@ void QOpenGLTextureGlyphCache::createTextureData(int width, int height)
     if (height < 16)
         height = 16;
 
-    if (m_textureResource && !m_textureResource->m_texture)
+    if (m_textureResource && !m_textureResource->m_texture) {
         delete m_textureResource;
+        m_textureResource = 0;
+    }
 
     if (!m_textureResource)
         m_textureResource = new QOpenGLGlyphTexture(ctx);
index c12a83a..8321b8d 100644 (file)
@@ -105,8 +105,10 @@ void QGLTextureGlyphCache::createTextureData(int width, int height)
     if (height < 16)
         height = 16;
 
-    if (m_textureResource && !m_textureResource->m_texture)
+    if (m_textureResource && !m_textureResource->m_texture) {
         delete m_textureResource;
+        m_textureResource = 0;
+    }
 
     if (!m_textureResource)
         m_textureResource = new QGLGlyphTexture(ctx);