mtd: rawnand: qcom: Simplify the call to nand_prog_page_end_op()
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Sat, 5 Aug 2023 17:41:44 +0000 (23:11 +0530)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Fri, 18 Aug 2023 14:34:31 +0000 (16:34 +0200)
Now that the dma desc cleanup is moved inside submit_descs(), let's
simplify the call to nand_prog_page_end_op() inside qcom_nandc_write_page()
and qcom_nandc_write_page_raw() to match other functions.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20230805174146.57006-9-manivannan.sadhasivam@linaro.org
drivers/mtd/nand/raw/qcom_nandc.c

index 483233f..f3eeb92 100644 (file)
@@ -2016,13 +2016,12 @@ static int qcom_nandc_write_page(struct nand_chip *chip, const u8 *buf,
        }
 
        ret = submit_descs(nandc);
-       if (ret)
+       if (ret) {
                dev_err(nandc->dev, "failure to write page\n");
+               return ret;
+       }
 
-       if (!ret)
-               ret = nand_prog_page_end_op(chip);
-
-       return ret;
+       return nand_prog_page_end_op(chip);
 }
 
 /* implements ecc->write_page_raw() */
@@ -2090,13 +2089,12 @@ static int qcom_nandc_write_page_raw(struct nand_chip *chip,
        }
 
        ret = submit_descs(nandc);
-       if (ret)
+       if (ret) {
                dev_err(nandc->dev, "failure to write raw page\n");
+               return ret;
+       }
 
-       if (!ret)
-               ret = nand_prog_page_end_op(chip);
-
-       return ret;
+       return nand_prog_page_end_op(chip);
 }
 
 /*