staging: comedi: adv_pci1710: cmd->scan_begin_src can only be TRIG_FOLLOW
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 23 Apr 2014 23:06:58 +0000 (16:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 22:07:40 +0000 (15:07 -0700)
In Step 1 of the (*do_cmdtest), the cmd->scan_begin_src is checked to
only allow TRIG_FOLLOW. The (*do_cmd) does not need to recheck this.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/adv_pci1710.c

index 9ce0535..60b926e 100644 (file)
@@ -1115,15 +1115,13 @@ static int pci171x_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
 {
        struct comedi_cmd *cmd = &s->async->cmd;
 
-       if (cmd->scan_begin_src == TRIG_FOLLOW) {       /*  mode 1, 2, 3 */
-               if (cmd->convert_src == TRIG_TIMER) {   /*  mode 1 and 2 */
-                       return pci171x_ai_docmd_and_mode(cmd->start_src ==
-                                                        TRIG_EXT ? 2 : 1, dev,
-                                                        s);
-               }
-               if (cmd->convert_src == TRIG_EXT) {     /*  mode 3 */
-                       return pci171x_ai_docmd_and_mode(3, dev, s);
-               }
+       if (cmd->convert_src == TRIG_TIMER) {   /*  mode 1 and 2 */
+               return pci171x_ai_docmd_and_mode(cmd->start_src ==
+                                                TRIG_EXT ? 2 : 1, dev,
+                                                s);
+       }
+       if (cmd->convert_src == TRIG_EXT) {     /*  mode 3 */
+               return pci171x_ai_docmd_and_mode(3, dev, s);
        }
 
        return -1;