perf report: Remove unnecessary check in annotate_browser_write()
authorJin Yao <yao.jin@linux.intel.com>
Thu, 4 May 2017 14:58:14 +0000 (22:58 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 19 Jun 2017 18:14:57 +0000 (15:14 -0300)
In annotate_browser_write(),

        if (dl->offset != -1 && percent_max != 0.0) {
                if (percent_max != 0.0) {
...
                }
                ...
        }

The second check of (percent_max != 0.0) is not necessary, remove it.

Signed-off-by: Yao Jin <yao.jin@linux.intel.com>
Acked-by: Milian Wolff <milian.wolff@kdab.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Yao Jin <yao.jin@linux.intel.com>
Link: http://lkml.kernel.org/r/1493909895-9668-2-git-send-email-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c

index d990ad0..52c1e8d 100644 (file)
@@ -132,21 +132,17 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
        }
 
        if (dl->offset != -1 && percent_max != 0.0) {
-               if (percent_max != 0.0) {
-                       for (i = 0; i < ab->nr_events; i++) {
-                               ui_browser__set_percent_color(browser,
-                                                       bdl->samples[i].percent,
-                                                       current_entry);
-                               if (annotate_browser__opts.show_total_period) {
-                                       ui_browser__printf(browser, "%6" PRIu64 " ",
-                                                          bdl->samples[i].nr);
-                               } else {
-                                       ui_browser__printf(browser, "%6.2f ",
-                                                          bdl->samples[i].percent);
-                               }
+               for (i = 0; i < ab->nr_events; i++) {
+                       ui_browser__set_percent_color(browser,
+                                               bdl->samples[i].percent,
+                                               current_entry);
+                       if (annotate_browser__opts.show_total_period) {
+                               ui_browser__printf(browser, "%6" PRIu64 " ",
+                                                  bdl->samples[i].nr);
+                       } else {
+                               ui_browser__printf(browser, "%6.2f ",
+                                                  bdl->samples[i].percent);
                        }
-               } else {
-                       ui_browser__write_nstring(browser, " ", 7 * ab->nr_events);
                }
        } else {
                ui_browser__set_percent_color(browser, 0, current_entry);