staging: r8188eu: convert rtw_free_drv_sw() to void
authorMichael Straube <straube.linux@gmail.com>
Sun, 2 Oct 2022 14:35:44 +0000 (16:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Oct 2022 15:19:49 +0000 (17:19 +0200)
The function rtw_free_drv_sw() always returns _SUCCESS. None of its
callers use the return value. Convert the return type of that function
from u8 to void. This is part of getting rid of _FAIL / _SUCCESS.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
Link: https://lore.kernel.org/r/20221002143544.7974-3-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/include/osdep_intf.h
drivers/staging/r8188eu/os_dep/os_intfs.c

index ce8e1bc..0f7d74a 100644 (file)
@@ -43,7 +43,7 @@ int netdev_open(struct net_device *pnetdev);
 int netdev_close(struct net_device *pnetdev);
 
 u8 rtw_init_drv_sw(struct adapter *padapter);
-u8 rtw_free_drv_sw(struct adapter *padapter);
+void rtw_free_drv_sw(struct adapter *padapter);
 void rtw_reset_drv_sw(struct adapter *padapter);
 
 u32 rtw_start_drv_threads(struct adapter *padapter);
index 2983e66..38e3247 100644 (file)
@@ -548,7 +548,7 @@ void rtw_cancel_all_timer(struct adapter *padapter)
        _cancel_timer_ex(&padapter->recvpriv.signal_stat_timer);
 }
 
-u8 rtw_free_drv_sw(struct adapter *padapter)
+void rtw_free_drv_sw(struct adapter *padapter)
 {
        /* we can call rtw_p2p_enable here, but: */
        /*  1. rtw_p2p_enable may have IO operation */
@@ -585,8 +585,6 @@ u8 rtw_free_drv_sw(struct adapter *padapter)
        /*  clear pbuddystruct adapter to avoid access wrong pointer. */
        if (padapter->pbuddy_adapter)
                padapter->pbuddy_adapter->pbuddy_adapter = NULL;
-
-       return _SUCCESS;
 }
 
 void netdev_br_init(struct net_device *netdev)