lkdtm: Prevent the compiler from optimising lkdtm_CORRUPT_STACK()
authorMichael Ellerman <mpe@ellerman.id.au>
Tue, 15 Nov 2016 07:02:32 +0000 (18:02 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Nov 2016 18:26:06 +0000 (19:26 +0100)
At least on powerpc with GCC 6, the compiler is smart enough to optimise
lkdtm_CORRUPT_STACK() into an empty function that just returns.

If we print the buffer after we've written to it that prevents the
compiler from optimising away data and the memset().

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/misc/lkdtm_bugs.c

index 182ae18..30e62dd 100644 (file)
@@ -80,7 +80,8 @@ noinline void lkdtm_CORRUPT_STACK(void)
        /* Use default char array length that triggers stack protection. */
        char data[8];
 
-       memset((void *)data, 0, 64);
+       memset((void *)data, 'a', 64);
+       pr_info("Corrupted stack with '%16s'...\n", data);
 }
 
 void lkdtm_UNALIGNED_LOAD_STORE_WRITE(void)