perf: Fix IS_ERR() vs NULL check in inherit_event()
authorGaosheng Cui <cuigaosheng1@huawei.com>
Mon, 14 Nov 2022 09:18:33 +0000 (17:18 +0800)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 15 Nov 2022 21:30:11 +0000 (22:30 +0100)
The find_get_pmu_context() returns an ERR_PTR() on failure, we should use
IS_ERR() to check the return value.

Fixes: bd2756811766 ("perf: Rewrite core context handling")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20221114091833.1492575-1-cuigaosheng1@huawei.com
kernel/events/core.c

index baa2997..baa6edf 100644 (file)
@@ -13171,7 +13171,7 @@ inherit_event(struct perf_event *parent_event,
                return child_event;
 
        pmu_ctx = find_get_pmu_context(child_event->pmu, child_ctx, child_event);
-       if (!pmu_ctx) {
+       if (IS_ERR(pmu_ctx)) {
                free_event(child_event);
                return NULL;
        }