soc: qcom: Invert the cooling states for the aoss warming devices
authorThara Gopinath <thara.gopinath@linaro.org>
Thu, 19 Sep 2019 16:18:22 +0000 (12:18 -0400)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 15 Oct 2019 03:42:16 +0000 (20:42 -0700)
Thermal framework takes 0 as the lowest/default state for a
cooling/warming device. The current code has the order inverted with 1
corresponding to lowest state in hardware and 0 the highest state.
Invert this for a better fit with the thermal framework.

Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/qcom_aoss.c

index 33a27e6..006ac40 100644 (file)
@@ -44,7 +44,7 @@
 
 #define QMP_NUM_COOLING_RESOURCES      2
 
-static bool qmp_cdev_init_state = 1;
+static bool qmp_cdev_max_state = 1;
 
 struct qmp_cooling_device {
        struct thermal_cooling_device *cdev;
@@ -402,7 +402,7 @@ static void qmp_pd_remove(struct qmp *qmp)
 static int qmp_cdev_get_max_state(struct thermal_cooling_device *cdev,
                                  unsigned long *state)
 {
-       *state = qmp_cdev_init_state;
+       *state = qmp_cdev_max_state;
        return 0;
 }
 
@@ -432,7 +432,7 @@ static int qmp_cdev_set_cur_state(struct thermal_cooling_device *cdev,
        snprintf(buf, sizeof(buf),
                 "{class: volt_flr, event:zero_temp, res:%s, value:%s}",
                        qmp_cdev->name,
-                       cdev_state ? "off" : "on");
+                       cdev_state ? "on" : "off");
 
        ret = qmp_send(qmp_cdev->qmp, buf, sizeof(buf));
 
@@ -455,7 +455,7 @@ static int qmp_cooling_device_add(struct qmp *qmp,
        char *cdev_name = (char *)node->name;
 
        qmp_cdev->qmp = qmp;
-       qmp_cdev->state = qmp_cdev_init_state;
+       qmp_cdev->state = !qmp_cdev_max_state;
        qmp_cdev->name = cdev_name;
        qmp_cdev->cdev = devm_thermal_of_cooling_device_register
                                (qmp->dev, node,