perf tests: Make terms a stack variable in test_term
authorDavid Ahern <dsahern@gmail.com>
Tue, 2 Jul 2013 19:27:24 +0000 (13:27 -0600)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 12 Jul 2013 16:46:17 +0000 (13:46 -0300)
No need to malloc the memory for it.

Signed-off-by: David Ahern <dsahern@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1372793245-4136-6-git-send-email-dsahern@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/tests/parse-events.c

index ad950f5..344c844 100644 (file)
@@ -1246,24 +1246,20 @@ static int test_events(struct evlist_test *events, unsigned cnt)
 
 static int test_term(struct terms_test *t)
 {
-       struct list_head *terms;
+       struct list_head terms;
        int ret;
 
-       terms = malloc(sizeof(*terms));
-       if (!terms)
-               return -ENOMEM;
-
-       INIT_LIST_HEAD(terms);
+       INIT_LIST_HEAD(&terms);
 
-       ret = parse_events_terms(terms, t->str);
+       ret = parse_events_terms(&terms, t->str);
        if (ret) {
                pr_debug("failed to parse terms '%s', err %d\n",
                         t->str , ret);
                return ret;
        }
 
-       ret = t->check(terms);
-       parse_events__free_terms(terms);
+       ret = t->check(&terms);
+       parse_events__free_terms(&terms);
 
        return ret;
 }