usb: dwc3: gadget: don't enable interrupt when disabling endpoint
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 13 Feb 2019 11:00:54 +0000 (13:00 +0200)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 13 Feb 2019 11:00:54 +0000 (13:00 +0200)
Since we're disabling the endpoint anyway, we don't worry about
getting endpoint command completion interrupt.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c

index 8425b6d..b63aa18 100644 (file)
@@ -687,12 +687,13 @@ out:
        return 0;
 }
 
-static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force);
+static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force,
+               bool interrupt);
 static void dwc3_remove_requests(struct dwc3 *dwc, struct dwc3_ep *dep)
 {
        struct dwc3_request             *req;
 
-       dwc3_stop_active_transfer(dep, true);
+       dwc3_stop_active_transfer(dep, true, false);
 
        /* - giveback all requests to gadget driver */
        while (!list_empty(&dep->started_list)) {
@@ -1350,7 +1351,7 @@ static int dwc3_gadget_start_isoc_quirk(struct dwc3_ep *dep)
                 * to wait for the next XferNotReady to test the command again
                 */
                if (cmd_status == 0) {
-                       dwc3_stop_active_transfer(dep, true);
+                       dwc3_stop_active_transfer(dep, true, true);
                        return 0;
                }
        }
@@ -1543,7 +1544,7 @@ static int dwc3_gadget_ep_dequeue(struct usb_ep *ep,
                }
                if (r == req) {
                        /* wait until it is processed */
-                       dwc3_stop_active_transfer(dep, true);
+                       dwc3_stop_active_transfer(dep, true, true);
 
                        if (!r->trb)
                                goto out0;
@@ -2500,7 +2501,7 @@ static void dwc3_gadget_endpoint_transfer_in_progress(struct dwc3_ep *dep,
        dwc3_gadget_ep_cleanup_completed_requests(dep, event, status);
 
        if (stop) {
-               dwc3_stop_active_transfer(dep, true);
+               dwc3_stop_active_transfer(dep, true, true);
                dep->flags = DWC3_EP_ENABLED;
        }
 
@@ -2621,7 +2622,8 @@ static void dwc3_reset_gadget(struct dwc3 *dwc)
        }
 }
 
-static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force)
+static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force,
+       bool interrupt)
 {
        struct dwc3 *dwc = dep->dwc;
        struct dwc3_gadget_ep_cmd_params params;
@@ -2664,7 +2666,7 @@ static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force)
 
        cmd = DWC3_DEPCMD_ENDTRANSFER;
        cmd |= force ? DWC3_DEPCMD_HIPRI_FORCERM : 0;
-       cmd |= DWC3_DEPCMD_CMDIOC;
+       cmd |= interrupt ? DWC3_DEPCMD_CMDIOC : 0;
        cmd |= DWC3_DEPCMD_PARAM(dep->resource_index);
        memset(&params, 0, sizeof(params));
        ret = dwc3_send_gadget_ep_cmd(dep, cmd, &params);