dt-bindings: clock: Require #reset-cells in sdm845-videocc
authorDouglas Anderson <dianders@chromium.org>
Tue, 27 Nov 2018 19:24:43 +0000 (11:24 -0800)
committerStephen Boyd <sboyd@kernel.org>
Fri, 30 Nov 2018 09:01:21 +0000 (01:01 -0800)
The #reset-cells was listed as optional in the bindings for
qcom,sdm845-videocc.  There's no reason for it to be optional.  As per
Stephen [1]:

> We should update the binding to make it a required property. It
> doesn't make any sense why that property would be optional given
> that the hardware either has support for resets or it doesn't.

sdm845 support is still in its infancy so we shouldn't be affecting
any real device trees by modifying the bindings here.

[1] https://lkml.kernel.org/r/154330186815.88331.12720647562079303842@swboyd.mtv.corp.google.com

Fixes: 84b66b211603 ("dt-bindings: clock: Introduce QCOM Video clock bindings")
Suggested-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Documentation/devicetree/bindings/clock/qcom,videocc.txt

index e7c035afa778fb3acade54d7645056f3460ceb38..8a8622c65c5aadb21f43fe1f63f4107f63d3b786 100644 (file)
@@ -6,8 +6,6 @@ Required properties :
 - reg : shall contain base register location and length
 - #clock-cells : from common clock binding, shall contain 1.
 - #power-domain-cells : from generic power domain binding, shall contain 1.
-
-Optional properties :
 - #reset-cells : from common reset binding, shall contain 1.
 
 Example:
@@ -16,4 +14,5 @@ Example:
                reg = <0xab00000 0x10000>;
                #clock-cells = <1>;
                #power-domain-cells = <1>;
+               #reset-cells = <1>;
        };