gpio: lp3943: remove unneeded platform_set_drvdata() call
authorAndrei Coardos <aboutphysycs@gmail.com>
Tue, 25 Jul 2023 10:25:32 +0000 (13:25 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 1 Aug 2023 19:14:48 +0000 (21:14 +0200)
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call, to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.

Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-lp3943.c

index 79edd5d..8e58242 100644 (file)
@@ -199,8 +199,6 @@ static int lp3943_gpio_probe(struct platform_device *pdev)
        lp3943_gpio->chip = lp3943_gpio_chip;
        lp3943_gpio->chip.parent = &pdev->dev;
 
-       platform_set_drvdata(pdev, lp3943_gpio);
-
        return devm_gpiochip_add_data(&pdev->dev, &lp3943_gpio->chip,
                                      lp3943_gpio);
 }