drm/i915: Clean up g4x+ sprite TILEOFF programming
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 14 Feb 2023 13:47:39 +0000 (15:47 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 16 Feb 2023 10:01:56 +0000 (12:01 +0200)
We defined the bitmasks for DVSTILEOFF but never used them.
Remedy that.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230214134739.25077-3-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/intel_sprite.c

index e6b4d24..a16e56a 100644 (file)
@@ -1217,7 +1217,8 @@ g4x_sprite_update_arm(struct intel_plane *plane,
        }
 
        intel_de_write_fw(dev_priv, DVSLINOFF(pipe), linear_offset);
-       intel_de_write_fw(dev_priv, DVSTILEOFF(pipe), (y << 16) | x);
+       intel_de_write_fw(dev_priv, DVSTILEOFF(pipe),
+                         DVS_OFFSET_Y(y) | DVS_OFFSET_X(x));
 
        /*
         * The control register self-arms if the plane was previously