projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
4e5552b
)
media: m88ds3103: error in set_frontend is swallowed and not reported
author
Sean Young
<sean@mess.org>
Thu, 16 Apr 2020 14:22:15 +0000
(16:22 +0200)
committer
Mauro Carvalho Chehab
<mchehab+huawei@kernel.org>
Wed, 29 Apr 2020 09:58:27 +0000
(11:58 +0200)
Bail out if registers can not be updated.
Addresses-Coverity-ID: 1461655 ("Code maintainability issues")
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Fixes:
e6089feca460
("media: m88ds3103: Add support for ds3103b demod")
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/dvb-frontends/m88ds3103.c
patch
|
blob
|
history
diff --git
a/drivers/media/dvb-frontends/m88ds3103.c
b/drivers/media/dvb-frontends/m88ds3103.c
index
bc356ac
..
f204e71
100644
(file)
--- a/
drivers/media/dvb-frontends/m88ds3103.c
+++ b/
drivers/media/dvb-frontends/m88ds3103.c
@@
-980,6
+980,8
@@
static int m88ds3103_set_frontend(struct dvb_frontend *fe)
goto err;
ret = m88ds3103_update_bits(dev, 0xc9, 0x08, 0x08);
+ if (ret)
+ goto err;
}
dev_dbg(&client->dev, "carrier offset=%d\n",