UBI: fix dereference after kfree

Coverity (CID 1614) spotted new_seb being dereferenced after kfree() in
create_vtbl's write_error path.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index b6fd6bb..83236c3 100644 (file)
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -317,14 +317,13 @@ retry:
        return err;
 
 write_error:
-       kfree(new_seb);
-       /* May be this physical eraseblock went bad, try to pick another one */
-       if (++tries <= 5) {
+       /* Maybe this physical eraseblock went bad, try to pick another one */
+       if (++tries <= 5)
                err = ubi_scan_add_to_list(si, new_seb->pnum, new_seb->ec,
                                           &si->corr);
-               if (!err)
-                       goto retry;
-       }
+       kfree(new_seb);
+       if (!err)
+               goto retry;
 out_free:
        ubi_free_vid_hdr(ubi, vid_hdr);
        return err;