Allow V8 bindings to assign to value type sub properties
authorAaron Kennedy <aaron.kennedy@nokia.com>
Thu, 23 Feb 2012 09:50:15 +0000 (09:50 +0000)
committerQt by Nokia <qt-info@nokia.com>
Fri, 24 Feb 2012 06:02:16 +0000 (07:02 +0100)
This was an overly defensive change because it wasn't clear if the isAlias
check would catch aliased value type sub properties.

Change-Id: Iee2805d22f281c1fd188b14e265687fd8e7042db
Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
src/declarative/qml/qdeclarativecompiler.cpp

index c4efc85..b7b882c 100644 (file)
@@ -3609,7 +3609,7 @@ bool QDeclarativeCompiler::completeComponentBuild()
         bool isSharable = false;
         binding.rewrittenExpression = rewriteBinding(binding.expression.asAST(), expression, &isSharable);
 
-        if (isSharable && !binding.property->isValueTypeSubProperty && !binding.property->isAlias /* See above re alias */ &&
+        if (isSharable && !binding.property->isAlias /* See above re alias */ &&
             binding.property->type != qMetaTypeId<QDeclarativeBinding*>()) {
             binding.dataType = BindingReference::V8;
             sharedBindings.append(b);