scsi: sd: Print write through due to no caching mode page as warning
authorMartin Kepplinger <martin.kepplinger@puri.sm>
Wed, 13 Oct 2021 07:50:50 +0000 (09:50 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 19 Oct 2021 02:38:34 +0000 (22:38 -0400)
For SD cardreaders it is extremely common not to have a cache.
Consequently, the following messages do not point to a real error one could
try to fix but rather describe how the disk works:

  sd 0:0:0:0: [sda] No Caching mode page found
  sd 0:0:0:0: [sda] Assuming drive cache: write through

Print these messages as warnings instead of errors.

Link: https://lore.kernel.org/r/20211013075050.3870354-1-martin.kepplinger@puri.sm
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c

index 4a78ab7185ebbd544b59a3ded3fff212dc477ea5..8b19d7cb5e96a58c8f71cef71714b52daf00c3ef 100644 (file)
@@ -2792,7 +2792,8 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer)
                        }
                }
 
-               sd_first_printk(KERN_ERR, sdkp, "No Caching mode page found\n");
+               sd_first_printk(KERN_WARNING, sdkp,
+                               "No Caching mode page found\n");
                goto defaults;
 
        Page_found:
@@ -2847,7 +2848,7 @@ defaults:
                                "Assuming drive cache: write back\n");
                sdkp->WCE = 1;
        } else {
-               sd_first_printk(KERN_ERR, sdkp,
+               sd_first_printk(KERN_WARNING, sdkp,
                                "Assuming drive cache: write through\n");
                sdkp->WCE = 0;
        }