bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler
authorKeerthy <j-keerthy@ti.com>
Mon, 10 Nov 2014 18:19:48 +0000 (23:49 +0530)
committerTony Lindgren <tony@atomide.com>
Wed, 12 Nov 2014 15:16:27 +0000 (07:16 -0800)
Correct returning IRQ_HANDLED unconditionally in the irq handler.
Return IRQ_NONE for some interrupt which we do not expect to be
handled in this handler. This prevents kernel stalling with back
to back spurious interrupts.

Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver")
Acked-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Keerthy <j-keerthy@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
drivers/bus/omap_l3_noc.c

index b5eac29..17d8659 100644 (file)
@@ -222,10 +222,14 @@ static irqreturn_t l3_interrupt_handler(int irq, void *_l3)
                        }
 
                        /* Error found so break the for loop */
-                       break;
+                       return IRQ_HANDLED;
                }
        }
-       return IRQ_HANDLED;
+
+       dev_err(l3->dev, "L3 %s IRQ not handled!!\n",
+               inttype ? "debug" : "application");
+
+       return IRQ_NONE;
 }
 
 static const struct of_device_id l3_noc_match[] = {