dt-bindings: input: gpio-keys: Fix interrupts in example
authorGeert Uytterhoeven <geert+renesas@glider.be>
Fri, 3 Dec 2021 13:35:06 +0000 (14:35 +0100)
committerRob Herring <robh@kernel.org>
Mon, 6 Dec 2021 20:16:59 +0000 (14:16 -0600)
The "interrupts" property in the example looks weird:
  - The type is not in the last cell,
  - Level interrupts don't work well with gpio-keys, as they keep the
    interrupt asserted as long as the key is pressed, causing an
    interrupt storm.

Use a more realistic falling-edge interrupt instead.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/47ecd2d8efcf09f8ab47de87a7bcfafc82208776.1638538079.git.geert+renesas@glider.be
Signed-off-by: Rob Herring <robh@kernel.org>
Documentation/devicetree/bindings/input/gpio-keys.yaml

index 060a309..dbe7ecc 100644 (file)
@@ -142,7 +142,7 @@ examples:
         down {
             label = "GPIO Key DOWN";
             linux,code = <108>;
-            interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
+            interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
         };
     };