USB: serial: f81232: use devm_kzalloc for port data
authorJi-Ze Hong (Peter Hong) <hpeter@gmail.com>
Thu, 30 Jan 2020 05:47:49 +0000 (13:47 +0800)
committerJohan Hovold <johan@kernel.org>
Tue, 25 Feb 2020 11:30:11 +0000 (12:30 +0100)
Use devm_kzalloc() to replace kzalloc() in port_probe().

Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/f81232.c

index 793d0b30e34717d48ef3821ca33c43ac83c2dc5b..e080d678b0c2732618225c15493365725622526a 100644 (file)
@@ -753,7 +753,7 @@ static int f81232_port_probe(struct usb_serial_port *port)
 {
        struct f81232_private *priv;
 
-       priv = kzalloc(sizeof(*priv), GFP_KERNEL);
+       priv = devm_kzalloc(&port->dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
@@ -769,16 +769,6 @@ static int f81232_port_probe(struct usb_serial_port *port)
        return 0;
 }
 
-static int f81232_port_remove(struct usb_serial_port *port)
-{
-       struct f81232_private *priv;
-
-       priv = usb_get_serial_port_data(port);
-       kfree(priv);
-
-       return 0;
-}
-
 static int f81232_suspend(struct usb_serial *serial, pm_message_t message)
 {
        struct usb_serial_port *port = serial->port[0];
@@ -838,7 +828,6 @@ static struct usb_serial_driver f81232_device = {
        .process_read_urb =     f81232_process_read_urb,
        .read_int_callback =    f81232_read_int_callback,
        .port_probe =           f81232_port_probe,
-       .port_remove =          f81232_port_remove,
        .suspend =              f81232_suspend,
        .resume =               f81232_resume,
 };