staging: rtl8192e: use BIT macro instead of left shifting
authorMoses Christopher Bollavarapu <mosescb.dev@gmail.com>
Sat, 19 Feb 2022 18:32:34 +0000 (19:32 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 21 Feb 2022 17:13:37 +0000 (18:13 +0100)
There is a BIT(nr) macro available in vdso/bits.h
which is doing the same left shift operation

Example: (1 << 7) == BIT(7)

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Link: https://lore.kernel.org/r/20220219183234.31216-1-mosescb.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_debug.h

index 9065901..e3e8302 100644 (file)
@@ -7,6 +7,8 @@
 #ifndef _RTL_DEBUG_H
 #define _RTL_DEBUG_H
 
+#include <linux/bits.h>
+
 /* Allow files to override DRV_NAME */
 #ifndef DRV_NAME
 #define DRV_NAME "rtllib_92e"
@@ -16,32 +18,32 @@ extern u32 rt_global_debug_component;
 
 /* These are the defines for rt_global_debug_component */
 enum RTL_DEBUG {
-       COMP_TRACE              = (1 << 0),
-       COMP_DBG                = (1 << 1),
-       COMP_INIT               = (1 << 2),
-       COMP_RECV               = (1 << 3),
-       COMP_POWER              = (1 << 6),
-       COMP_SWBW               = (1 << 8),
-       COMP_SEC                = (1 << 9),
-       COMP_LPS                = (1 << 10),
-       COMP_QOS                = (1 << 11),
-       COMP_RATE               = (1 << 12),
-       COMP_RXDESC             = (1 << 13),
-       COMP_PHY                = (1 << 14),
-       COMP_DIG                = (1 << 15),
-       COMP_TXAGC              = (1 << 16),
-       COMP_HALDM              = (1 << 17),
-       COMP_POWER_TRACKING     = (1 << 18),
-       COMP_CH                 = (1 << 19),
-       COMP_RF                 = (1 << 20),
-       COMP_FIRMWARE           = (1 << 21),
-       COMP_RESET              = (1 << 23),
-       COMP_CMDPKT             = (1 << 24),
-       COMP_SCAN               = (1 << 25),
-       COMP_PS                 = (1 << 26),
-       COMP_DOWN               = (1 << 27),
-       COMP_INTR               = (1 << 28),
-       COMP_ERR                = (1 << 31)
+       COMP_TRACE              = BIT(0),
+       COMP_DBG                = BIT(1),
+       COMP_INIT               = BIT(2),
+       COMP_RECV               = BIT(3),
+       COMP_POWER              = BIT(6),
+       COMP_SWBW               = BIT(8),
+       COMP_SEC                = BIT(9),
+       COMP_LPS                = BIT(10),
+       COMP_QOS                = BIT(11),
+       COMP_RATE               = BIT(12),
+       COMP_RXDESC             = BIT(13),
+       COMP_PHY                = BIT(14),
+       COMP_DIG                = BIT(15),
+       COMP_TXAGC              = BIT(16),
+       COMP_HALDM              = BIT(17),
+       COMP_POWER_TRACKING     = BIT(18),
+       COMP_CH                 = BIT(19),
+       COMP_RF                 = BIT(20),
+       COMP_FIRMWARE           = BIT(21),
+       COMP_RESET              = BIT(23),
+       COMP_CMDPKT             = BIT(24),
+       COMP_SCAN               = BIT(25),
+       COMP_PS                 = BIT(26),
+       COMP_DOWN               = BIT(27),
+       COMP_INTR               = BIT(28),
+       COMP_ERR                = BIT(31)
 };
 
 #define RT_TRACE(component, x, args...)                \