media: mtk-vpu: fix two smatch warnings
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Sun, 3 Nov 2019 11:23:33 +0000 (12:23 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Fri, 8 Nov 2019 06:25:39 +0000 (07:25 +0100)
Drop the "id >= 0" test in two conditions to fix these warnings:

drivers/media/platform/mtk-vpu/mtk_vpu.c:276 vpu_ipi_register() warn: always true condition '(id >= 0) => (0-u32max >= 0)'
drivers/media/platform/mtk-vpu/mtk_vpu.c:401 vpu_wdt_reg_handler() warn: always true condition '(id >= 0) => (0-u32max >= 0)'

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/platform/mtk-vpu/mtk_vpu.c

index cc2ff40..a768707 100644 (file)
@@ -273,7 +273,7 @@ int vpu_ipi_register(struct platform_device *pdev,
                return -EPROBE_DEFER;
        }
 
-       if (id >= 0 && id < IPI_MAX && handler) {
+       if (id < IPI_MAX && handler) {
                ipi_desc = vpu->ipi_desc;
                ipi_desc[id].name = name;
                ipi_desc[id].handler = handler;
@@ -398,7 +398,7 @@ int vpu_wdt_reg_handler(struct platform_device *pdev,
 
        handler = vpu->wdt.handler;
 
-       if (id >= 0 && id < VPU_RST_MAX && wdt_reset) {
+       if (id < VPU_RST_MAX && wdt_reset) {
                dev_dbg(vpu->dev, "wdt register id %d\n", id);
                mutex_lock(&vpu->vpu_mutex);
                handler[id].reset_func = wdt_reset;