mfd: Constify static struct resources
authorRikard Falkeborn <rikard.falkeborn@gmail.com>
Tue, 22 Sep 2020 19:26:59 +0000 (21:26 +0200)
committerLee Jones <lee.jones@linaro.org>
Thu, 19 Nov 2020 08:34:21 +0000 (08:34 +0000)
Constify a number of static struct resource. The only usage of the
structs are to assign their address to the resources field in the
mfd_cell struct. This allows the compiler to put them in read-only
memory. Done with the help of Coccinelle.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
15 files changed:
drivers/mfd/88pm800.c
drivers/mfd/88pm860x-core.c
drivers/mfd/hi655x-pmic.c
drivers/mfd/intel_quark_i2c_gpio.c
drivers/mfd/ioc3.c
drivers/mfd/max8925-core.c
drivers/mfd/rdc321x-southbridge.c
drivers/mfd/retu-mfd.c
drivers/mfd/rk808.c
drivers/mfd/tc3589x.c
drivers/mfd/tc6387xb.c
drivers/mfd/tc6393xb.c
drivers/mfd/tps65090.c
drivers/mfd/tps6586x.c
drivers/mfd/tps80031.c

index 4e8d0d6..c7f9649 100644 (file)
@@ -121,7 +121,7 @@ static const struct i2c_device_id pm80x_id_table[] = {
 };
 MODULE_DEVICE_TABLE(i2c, pm80x_id_table);
 
-static struct resource rtc_resources[] = {
+static const struct resource rtc_resources[] = {
        {
         .name = "88pm80x-rtc",
         .start = PM800_IRQ_RTC,
index c9bae71..b1e829e 100644 (file)
 
 #define INT_STATUS_NUM                 3
 
-static struct resource bk0_resources[] = {
+static const struct resource bk0_resources[] = {
        {2, 2, "duty cycle", IORESOURCE_REG, },
        {3, 3, "always on",  IORESOURCE_REG, },
        {3, 3, "current",    IORESOURCE_REG, },
 };
-static struct resource bk1_resources[] = {
+static const struct resource bk1_resources[] = {
        {4, 4, "duty cycle", IORESOURCE_REG, },
        {5, 5, "always on",  IORESOURCE_REG, },
        {5, 5, "current",    IORESOURCE_REG, },
 };
-static struct resource bk2_resources[] = {
+static const struct resource bk2_resources[] = {
        {6, 6, "duty cycle", IORESOURCE_REG, },
        {7, 7, "always on",  IORESOURCE_REG, },
        {5, 5, "current",    IORESOURCE_REG, },
 };
 
-static struct resource led0_resources[] = {
+static const struct resource led0_resources[] = {
        /* RGB1 Red LED */
        {0xd, 0xd, "control", IORESOURCE_REG, },
        {0xc, 0xc, "blink",   IORESOURCE_REG, },
 };
-static struct resource led1_resources[] = {
+static const struct resource led1_resources[] = {
        /* RGB1 Green LED */
        {0xe, 0xe, "control", IORESOURCE_REG, },
        {0xc, 0xc, "blink",   IORESOURCE_REG, },
 };
-static struct resource led2_resources[] = {
+static const struct resource led2_resources[] = {
        /* RGB1 Blue LED */
        {0xf, 0xf, "control", IORESOURCE_REG, },
        {0xc, 0xc, "blink",   IORESOURCE_REG, },
 };
-static struct resource led3_resources[] = {
+static const struct resource led3_resources[] = {
        /* RGB2 Red LED */
        {0x9, 0x9, "control", IORESOURCE_REG, },
        {0x8, 0x8, "blink",   IORESOURCE_REG, },
 };
-static struct resource led4_resources[] = {
+static const struct resource led4_resources[] = {
        /* RGB2 Green LED */
        {0xa, 0xa, "control", IORESOURCE_REG, },
        {0x8, 0x8, "blink",   IORESOURCE_REG, },
 };
-static struct resource led5_resources[] = {
+static const struct resource led5_resources[] = {
        /* RGB2 Blue LED */
        {0xb, 0xb, "control", IORESOURCE_REG, },
        {0x8, 0x8, "blink",   IORESOURCE_REG, },
 };
 
-static struct resource buck1_resources[] = {
+static const struct resource buck1_resources[] = {
        {0x24, 0x24, "buck set", IORESOURCE_REG, },
 };
-static struct resource buck2_resources[] = {
+static const struct resource buck2_resources[] = {
        {0x25, 0x25, "buck set", IORESOURCE_REG, },
 };
-static struct resource buck3_resources[] = {
+static const struct resource buck3_resources[] = {
        {0x26, 0x26, "buck set", IORESOURCE_REG, },
 };
-static struct resource ldo1_resources[] = {
+static const struct resource ldo1_resources[] = {
        {0x10, 0x10, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo2_resources[] = {
+static const struct resource ldo2_resources[] = {
        {0x11, 0x11, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo3_resources[] = {
+static const struct resource ldo3_resources[] = {
        {0x12, 0x12, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo4_resources[] = {
+static const struct resource ldo4_resources[] = {
        {0x13, 0x13, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo5_resources[] = {
+static const struct resource ldo5_resources[] = {
        {0x14, 0x14, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo6_resources[] = {
+static const struct resource ldo6_resources[] = {
        {0x15, 0x15, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo7_resources[] = {
+static const struct resource ldo7_resources[] = {
        {0x16, 0x16, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo8_resources[] = {
+static const struct resource ldo8_resources[] = {
        {0x17, 0x17, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo9_resources[] = {
+static const struct resource ldo9_resources[] = {
        {0x18, 0x18, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo10_resources[] = {
+static const struct resource ldo10_resources[] = {
        {0x19, 0x19, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo12_resources[] = {
+static const struct resource ldo12_resources[] = {
        {0x1a, 0x1a, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo_vibrator_resources[] = {
+static const struct resource ldo_vibrator_resources[] = {
        {0x28, 0x28, "ldo set", IORESOURCE_REG, },
 };
-static struct resource ldo14_resources[] = {
+static const struct resource ldo14_resources[] = {
        {0x1b, 0x1b, "ldo set", IORESOURCE_REG, },
 };
 
index 7e3959a..d3c86a7 100644 (file)
@@ -49,7 +49,7 @@ static struct regmap_config hi655x_regmap_config = {
        .max_register = HI655X_BUS_ADDR(0x400) - HI655X_STRIDE,
 };
 
-static struct resource pwrkey_resources[] = {
+static const struct resource pwrkey_resources[] = {
        {
                .name   = "down",
                .start  = PWRON_D20R_INT,
index 84ca790..fe8ca94 100644 (file)
@@ -72,7 +72,7 @@ static const struct dmi_system_id dmi_platform_info[] = {
        {}
 };
 
-static struct resource intel_quark_i2c_res[] = {
+static const struct resource intel_quark_i2c_res[] = {
        [INTEL_QUARK_IORES_MEM] = {
                .flags = IORESOURCE_MEM,
        },
@@ -85,7 +85,7 @@ static struct mfd_cell_acpi_match intel_quark_acpi_match_i2c = {
        .adr = MFD_ACPI_MATCH_I2C,
 };
 
-static struct resource intel_quark_gpio_res[] = {
+static const struct resource intel_quark_gpio_res[] = {
        [INTEL_QUARK_IORES_MEM] = {
                .flags = IORESOURCE_MEM,
        },
index d939ccc..c73ec78 100644 (file)
@@ -158,13 +158,13 @@ err:
        return -ENOMEM;
 }
 
-static struct resource ioc3_uarta_resources[] = {
+static const struct resource ioc3_uarta_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, sregs.uarta),
                       sizeof_field(struct ioc3, sregs.uarta)),
        DEFINE_RES_IRQ(IOC3_IRQ_SERIAL_A)
 };
 
-static struct resource ioc3_uartb_resources[] = {
+static const struct resource ioc3_uartb_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, sregs.uartb),
                       sizeof_field(struct ioc3, sregs.uartb)),
        DEFINE_RES_IRQ(IOC3_IRQ_SERIAL_B)
@@ -213,7 +213,7 @@ static int ioc3_serial_setup(struct ioc3_priv_data *ipd)
        return 0;
 }
 
-static struct resource ioc3_kbd_resources[] = {
+static const struct resource ioc3_kbd_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, serio),
                       sizeof_field(struct ioc3, serio)),
        DEFINE_RES_IRQ(IOC3_IRQ_KBD)
@@ -242,7 +242,7 @@ static int ioc3_kbd_setup(struct ioc3_priv_data *ipd)
        return 0;
 }
 
-static struct resource ioc3_eth_resources[] = {
+static const struct resource ioc3_eth_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, eth),
                       sizeof_field(struct ioc3, eth)),
        DEFINE_RES_MEM(offsetof(struct ioc3, ssram),
@@ -250,7 +250,7 @@ static struct resource ioc3_eth_resources[] = {
        DEFINE_RES_IRQ(0)
 };
 
-static struct resource ioc3_w1_resources[] = {
+static const struct resource ioc3_w1_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, mcr),
                       sizeof_field(struct ioc3, mcr)),
 };
@@ -294,7 +294,7 @@ static int ioc3_eth_setup(struct ioc3_priv_data *ipd)
        return 0;
 }
 
-static struct resource ioc3_m48t35_resources[] = {
+static const struct resource ioc3_m48t35_resources[] = {
        DEFINE_RES_MEM(IOC3_BYTEBUS_DEV0, M48T35_REG_SIZE)
 };
 
@@ -326,7 +326,7 @@ static struct ds1685_rtc_platform_data ip30_rtc_platform_data = {
        .access_type = ds1685_reg_indirect,
 };
 
-static struct resource ioc3_rtc_ds1685_resources[] = {
+static const struct resource ioc3_rtc_ds1685_resources[] = {
        DEFINE_RES_MEM(IOC3_BYTEBUS_DEV1, 1),
        DEFINE_RES_MEM(IOC3_BYTEBUS_DEV2, 1),
        DEFINE_RES_IRQ(0)
@@ -359,7 +359,7 @@ static int ioc3_ds1685_setup(struct ioc3_priv_data *ipd)
 };
 
 
-static struct resource ioc3_leds_resources[] = {
+static const struct resource ioc3_leds_resources[] = {
        DEFINE_RES_MEM(offsetof(struct ioc3, gppr[0]),
                       sizeof_field(struct ioc3, gppr[0])),
        DEFINE_RES_MEM(offsetof(struct ioc3, gppr[1]),
index 0af6833..eb3f061 100644 (file)
@@ -19,7 +19,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 
-static struct resource bk_resources[] = {
+static const struct resource bk_resources[] = {
        { 0x84, 0x84, "mode control", IORESOURCE_REG, },
        { 0x85, 0x85, "control",      IORESOURCE_REG, },
 };
@@ -33,7 +33,7 @@ static struct mfd_cell bk_devs[] = {
        },
 };
 
-static struct resource touch_resources[] = {
+static const struct resource touch_resources[] = {
        {
                .name   = "max8925-tsc",
                .start  = MAX8925_TSC_IRQ,
@@ -51,7 +51,7 @@ static const struct mfd_cell touch_devs[] = {
        },
 };
 
-static struct resource power_supply_resources[] = {
+static const struct resource power_supply_resources[] = {
        {
                .name   = "max8925-power",
                .start  = MAX8925_CHG_IRQ1,
@@ -69,7 +69,7 @@ static const struct mfd_cell power_devs[] = {
        },
 };
 
-static struct resource rtc_resources[] = {
+static const struct resource rtc_resources[] = {
        {
                .name   = "max8925-rtc",
                .start  = MAX8925_IRQ_RTC_ALARM0,
@@ -87,7 +87,7 @@ static const struct mfd_cell rtc_devs[] = {
        },
 };
 
-static struct resource onkey_resources[] = {
+static const struct resource onkey_resources[] = {
        {
                .name   = "max8925-onkey",
                .start  = MAX8925_IRQ_GPM_SW_R,
@@ -110,95 +110,95 @@ static const struct mfd_cell onkey_devs[] = {
        },
 };
 
-static struct resource sd1_resources[] = {
+static const struct resource sd1_resources[] = {
        {0x06, 0x06, "sdv", IORESOURCE_REG, },
 };
 
-static struct resource sd2_resources[] = {
+static const struct resource sd2_resources[] = {
        {0x09, 0x09, "sdv", IORESOURCE_REG, },
 };
 
-static struct resource sd3_resources[] = {
+static const struct resource sd3_resources[] = {
        {0x0c, 0x0c, "sdv", IORESOURCE_REG, },
 };
 
-static struct resource ldo1_resources[] = {
+static const struct resource ldo1_resources[] = {
        {0x1a, 0x1a, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo2_resources[] = {
+static const struct resource ldo2_resources[] = {
        {0x1e, 0x1e, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo3_resources[] = {
+static const struct resource ldo3_resources[] = {
        {0x22, 0x22, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo4_resources[] = {
+static const struct resource ldo4_resources[] = {
        {0x26, 0x26, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo5_resources[] = {
+static const struct resource ldo5_resources[] = {
        {0x2a, 0x2a, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo6_resources[] = {
+static const struct resource ldo6_resources[] = {
        {0x2e, 0x2e, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo7_resources[] = {
+static const struct resource ldo7_resources[] = {
        {0x32, 0x32, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo8_resources[] = {
+static const struct resource ldo8_resources[] = {
        {0x36, 0x36, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo9_resources[] = {
+static const struct resource ldo9_resources[] = {
        {0x3a, 0x3a, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo10_resources[] = {
+static const struct resource ldo10_resources[] = {
        {0x3e, 0x3e, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo11_resources[] = {
+static const struct resource ldo11_resources[] = {
        {0x42, 0x42, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo12_resources[] = {
+static const struct resource ldo12_resources[] = {
        {0x46, 0x46, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo13_resources[] = {
+static const struct resource ldo13_resources[] = {
        {0x4a, 0x4a, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo14_resources[] = {
+static const struct resource ldo14_resources[] = {
        {0x4e, 0x4e, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo15_resources[] = {
+static const struct resource ldo15_resources[] = {
        {0x52, 0x52, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo16_resources[] = {
+static const struct resource ldo16_resources[] = {
        {0x12, 0x12, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo17_resources[] = {
+static const struct resource ldo17_resources[] = {
        {0x16, 0x16, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo18_resources[] = {
+static const struct resource ldo18_resources[] = {
        {0x74, 0x74, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo19_resources[] = {
+static const struct resource ldo19_resources[] = {
        {0x5e, 0x5e, "ldov", IORESOURCE_REG, },
 };
 
-static struct resource ldo20_resources[] = {
+static const struct resource ldo20_resources[] = {
        {0x9e, 0x9e, "ldov", IORESOURCE_REG, },
 };
 
index fbb1faf..c44a762 100644 (file)
@@ -14,7 +14,7 @@
 
 static struct rdc321x_wdt_pdata rdc321x_wdt_pdata;
 
-static struct resource rdc321x_wdt_resource[] = {
+static const struct resource rdc321x_wdt_resource[] = {
        {
                .name   = "wdt-reg",
                .start  = RDC321X_WDT_CTRL,
@@ -27,7 +27,7 @@ static struct rdc321x_gpio_pdata rdc321x_gpio_pdata = {
        .max_gpios      = RDC321X_NUM_GPIO,
 };
 
-static struct resource rdc321x_gpio_resources[] = {
+static const struct resource rdc321x_gpio_resources[] = {
        {
                .name   = "gpio-reg1",
                .start  = RDC321X_GPIO_CTRL_REG1,
index e7d27b7..c748fd2 100644 (file)
@@ -45,7 +45,7 @@ struct retu_dev {
        struct regmap_irq_chip_data     *irq_data;
 };
 
-static struct resource retu_pwrbutton_res[] = {
+static const struct resource retu_pwrbutton_res[] = {
        {
                .name   = "retu-pwrbutton",
                .start  = RETU_INT_PWR,
@@ -84,7 +84,7 @@ static struct regmap_irq_chip retu_irq_chip = {
 /* Retu device registered for the power off. */
 static struct retu_dev *retu_pm_power_off;
 
-static struct resource tahvo_usb_res[] = {
+static const struct resource tahvo_usb_res[] = {
        {
                .name   = "tahvo-usb",
                .start  = TAHVO_INT_VBUS,
index d109b9f..ad923dd 100644 (file)
@@ -107,20 +107,20 @@ static const struct regmap_config rk817_regmap_config = {
        .volatile_reg = rk817_is_volatile_reg,
 };
 
-static struct resource rtc_resources[] = {
+static const struct resource rtc_resources[] = {
        DEFINE_RES_IRQ(RK808_IRQ_RTC_ALARM),
 };
 
-static struct resource rk817_rtc_resources[] = {
+static const struct resource rk817_rtc_resources[] = {
        DEFINE_RES_IRQ(RK817_IRQ_RTC_ALARM),
 };
 
-static struct resource rk805_key_resources[] = {
+static const struct resource rk805_key_resources[] = {
        DEFINE_RES_IRQ(RK805_IRQ_PWRON_RISE),
        DEFINE_RES_IRQ(RK805_IRQ_PWRON_FALL),
 };
 
-static struct resource rk817_pwrkey_resources[] = {
+static const struct resource rk817_pwrkey_resources[] = {
        DEFINE_RES_IRQ(RK817_IRQ_PWRON_RISE),
        DEFINE_RES_IRQ(RK817_IRQ_PWRON_FALL),
 };
index 7882a37..7614f8f 100644 (file)
@@ -141,7 +141,7 @@ out:
 }
 EXPORT_SYMBOL_GPL(tc3589x_set_bits);
 
-static struct resource gpio_resources[] = {
+static const struct resource gpio_resources[] = {
        {
                .start  = TC3589x_INT_GPIIRQ,
                .end    = TC3589x_INT_GPIIRQ,
@@ -149,7 +149,7 @@ static struct resource gpio_resources[] = {
        },
 };
 
-static struct resource keypad_resources[] = {
+static const struct resource keypad_resources[] = {
        {
                .start  = TC3589x_INT_KBDIRQ,
                .end    = TC3589x_INT_KBDIRQ,
index c66a701..e846e4d 100644 (file)
@@ -25,7 +25,7 @@ struct tc6387xb {
        struct resource rscr;
 };
 
-static struct resource tc6387xb_mmc_resources[] = {
+static const struct resource tc6387xb_mmc_resources[] = {
        {
                .start = 0x800,
                .end   = 0x9ff,
index 05d5059..3d5b14c 100644 (file)
@@ -133,7 +133,7 @@ static int tc6393xb_nand_enable(struct platform_device *nand)
        return 0;
 }
 
-static struct resource tc6393xb_nand_resources[] = {
+static const struct resource tc6393xb_nand_resources[] = {
        {
                .start  = 0x1000,
                .end    = 0x1007,
@@ -151,7 +151,7 @@ static struct resource tc6393xb_nand_resources[] = {
        },
 };
 
-static struct resource tc6393xb_mmc_resources[] = {
+static const struct resource tc6393xb_mmc_resources[] = {
        {
                .start  = 0x800,
                .end    = 0x9ff,
@@ -192,7 +192,7 @@ static const struct resource tc6393xb_ohci_resources[] = {
        },
 };
 
-static struct resource tc6393xb_fb_resources[] = {
+static const struct resource tc6393xb_fb_resources[] = {
        {
                .start  = 0x5000,
                .end    = 0x51ff,
index 6cdf6c3..bd62353 100644 (file)
@@ -38,7 +38,7 @@
 #define TPS65090_INT2_MASK_OVERLOAD_FET6               6
 #define TPS65090_INT2_MASK_OVERLOAD_FET7               7
 
-static struct resource charger_resources[] = {
+static const struct resource charger_resources[] = {
        {
                .start  = TPS65090_IRQ_VAC_STATUS_CHANGE,
                .end    = TPS65090_IRQ_VAC_STATUS_CHANGE,
index c365977..c9303d3 100644 (file)
@@ -92,7 +92,7 @@ static const struct tps6586x_irq_data tps6586x_irqs[] = {
        [TPS6586X_INT_RTC_ALM2] = TPS6586X_IRQ(TPS6586X_INT_MASK4, 1 << 1),
 };
 
-static struct resource tps6586x_rtc_resources[] = {
+static const struct resource tps6586x_rtc_resources[] = {
        {
                .start  = TPS6586X_INT_RTC_ALM1,
                .end    = TPS6586X_INT_RTC_ALM1,
index 907452b..902e335 100644 (file)
@@ -34,7 +34,7 @@
 #include <linux/regmap.h>
 #include <linux/slab.h>
 
-static struct resource tps80031_rtc_resources[] = {
+static const struct resource tps80031_rtc_resources[] = {
        {
                .start = TPS80031_INT_RTC_ALARM,
                .end = TPS80031_INT_RTC_ALARM,