net: marvell: prestera: use netif_is_any_bridge_port instead of open code
authorJuhee Kang <claudiajkang@gmail.com>
Thu, 21 Jul 2022 10:26:48 +0000 (19:26 +0900)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 Jul 2022 11:35:45 +0000 (12:35 +0100)
The open code which is netif_is_bridge_port() || netif_is_ovs_port() is
defined as a new helper function on netdev.h like netif_is_any_bridge_port
that can check both IFF flags in 1 go. So use netif_is_any_bridge_port()
function instead of open code. This patch doesn't change logic.

Signed-off-by: Juhee Kang <claudiajkang@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/prestera/prestera_router.c

index 3c8116f..58f4e44 100644 (file)
@@ -389,8 +389,8 @@ static int __prestera_inetaddr_event(struct prestera_switch *sw,
                                     unsigned long event,
                                     struct netlink_ext_ack *extack)
 {
-       if (!prestera_netdev_check(dev) || netif_is_bridge_port(dev) ||
-           netif_is_lag_port(dev) || netif_is_ovs_port(dev))
+       if (!prestera_netdev_check(dev) || netif_is_any_bridge_port(dev) ||
+           netif_is_lag_port(dev))
                return 0;
 
        return __prestera_inetaddr_port_event(dev, event, extack);