Removed unnecessary bloat & fix readme

Change-Id: Iafa766759f035a2b9f5d4232d0b16eac46781f4e

diff --git a/AUTHORS b/AUTHORS
index a62936f..0dc1e22 100644 (file)
--- a/AUTHORS
+++ b/AUTHORS
@@ -1 +1 @@
-Bumjin Im <bj.i@samsung.com>
+Tomasz Swierczek <t.swierczek@samsung.com>

diff --git a/README b/README
index 0959d36..82100fa 100644 (file)
--- a/README
+++ b/README
@@ -1,7 +1,6 @@
 README for security-manager project
 
-The security manager is project forked from security-server, from which
-it inherits its main design: division for two parts:
+security-manager consists of two elements:
 * system daemon (security-manager)
 * library for communication with daemon (libsecurity-manager).
 
@@ -15,9 +14,10 @@ and
     directory that defines actions done by security-manager after receiving
     certain requests from client side.
 
-The security-manager's manager part is fully inherited from security-server,
-while services are completely diffrent.
-
 The security-manager services are ment to gather information about security
 permissions in the system and provide access to that data via means of
 libsecurity-manager.
+
+More detailed information about the module can be found in the public wiki:
+
+https://wiki.tizen.org/Security/Tizen_3.X_Security_Manager

diff --git a/src/client/client-security-manager.cpp b/src/client/client-security-manager.cpp
index 62d3faa..f0e8b54 100644 (file)
--- a/src/client/client-security-manager.cpp
+++ b/src/client/client-security-manager.cpp
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014-2022 Samsung Electronics Co., Ltd. All rights reserved
+ * Copyright (c) 2014-2024 Samsung Electronics Co., Ltd. All rights reserved
  *
  * This file is licensed under the terms of MIT License or the Apache License
  * Version 2.0 of your choice. See the LICENSE.MIT file for MIT license details.
@@ -21,8 +21,7 @@
 
 /*
  * @file        client-security-manager.cpp
- * @author      Pawel Polawski <p.polawski@samsung.com>
- * @author      Rafal Krypa <r.krypa@samsung.com>
+ * @author      Tomasz Swierczek <t.swierczek@samsung.com>
  * @version     1.0
  * @brief       This file contain client side implementation of security-manager API
  */
@@ -462,25 +461,6 @@ int security_manager_get_app_pkgid(char **pkg_name, const char *app_name)
     });
 }
 
-static int setup_smack(const char *label)
-{
-    /* Here we also should change open socket labels for future process identification.
-       However, since Smack support for "dyntransition"-like feature will be enabled soon,
-       relabeling the sockets will no longer be possible.
-
-       After careful review it was found that only opened sockets are ones to systemd
-       (user and system session) and enlightment. Both services are not integrated with Cynara
-       and seem to be fine with these sockets retaining IPIN/IPOUT "User" label.
-    */
-    // Set Smack label of current process
-    if (smack_set_label_for_self(label) != 0) {
-        LogError("Failed to set Smack label for application: " << label);
-        return SECURITY_MANAGER_ERROR_UNKNOWN;
-    }
-
-    return SECURITY_MANAGER_SUCCESS;
-}
-
 static int fetchLabelForProcess(const std::string &appName, std::string &label)
 {
     ClientRequest request(SecurityModuleCall::GET_PROCESS_LABEL);
@@ -511,9 +491,9 @@ int security_manager_set_process_label_from_appid(const char *app_name)
         return SECURITY_MANAGER_ERROR_NO_SUCH_OBJECT;
     }
 
-    if ((ret = setup_smack(appLabel.c_str())) != SECURITY_MANAGER_SUCCESS) {
+    if (smack_set_label_for_self(appLabel.c_str()) != 0) {
         LogError("Failed to set smack label " << appLabel << " for current process");
-        return ret;
+        return SECURITY_MANAGER_ERROR_UNKNOWN;
     }
 
     return SECURITY_MANAGER_SUCCESS;