drm/bridge: analogix: Remove unreachable code from analogic_dp_core.c
authorSylwester Nawrocki <s.nawrocki@samsung.com>
Tue, 12 Dec 2017 11:20:37 +0000 (12:20 +0100)
committerArchit Taneja <architt@codeaurora.org>
Tue, 9 Jan 2018 10:46:55 +0000 (16:16 +0530)
This patch removes an unreachable code found by the SVACE static
analysis:

UNREACHABLE_CODE: This statement in the source code might be unreachable
during program execution.
[unreachable] unreachable at drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:787
retval != 0 is always false because at this program point the variable retval
is always equal to 0 at drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:786

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Archit Taneja <architt@codeaurora.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20171212112037.13107-1-s.nawrocki@samsung.com
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c

index 5dd3f1c..263e821 100644 (file)
@@ -727,7 +727,6 @@ static int analogix_dp_set_link_train(struct analogix_dp_device *dp,
 
 static int analogix_dp_config_video(struct analogix_dp_device *dp)
 {
-       int retval = 0;
        int timeout_loop = 0;
        int done_count = 0;
 
@@ -783,10 +782,7 @@ static int analogix_dp_config_video(struct analogix_dp_device *dp)
                usleep_range(1000, 1001);
        }
 
-       if (retval != 0)
-               dev_err(dp->dev, "Video stream is not detected!\n");
-
-       return retval;
+       return 0;
 }
 
 static void analogix_dp_enable_scramble(struct analogix_dp_device *dp,