xfs: fix ->mknod() return value on xfs_get_acl() failure
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 5 Jun 2011 11:12:31 +0000 (11:12 +0000)
committerAlex Elder <aelder@sgi.com>
Tue, 14 Jun 2011 16:02:13 +0000 (11:02 -0500)
->mknod() should return negative on errors and PTR_ERR() gives
already negative value...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>
fs/xfs/linux-2.6/xfs_iops.c

index dd21784..d44d92c 100644 (file)
@@ -182,7 +182,7 @@ xfs_vn_mknod(
        if (IS_POSIXACL(dir)) {
                default_acl = xfs_get_acl(dir, ACL_TYPE_DEFAULT);
                if (IS_ERR(default_acl))
-                       return -PTR_ERR(default_acl);
+                       return PTR_ERR(default_acl);
 
                if (!default_acl)
                        mode &= ~current_umask();