updated doxygen comments

Change-Id: I396f145ce439390bb509ece3d3a02c7e0101b96d
Signed-off-by: Jiban Prakash <p.jiban@samsung.com>

diff --git a/inc/FShellAppWidgetManager.h b/inc/FShellAppWidgetManager.h
index 33089b2..9ca5065 100755 (executable)
--- a/inc/FShellAppWidgetManager.h
+++ b/inc/FShellAppWidgetManager.h
@@ -179,7 +179,7 @@ private:
        static AppWidgetManager* __pTheInstance;
        class _AppWidgetManagerImpl* __pAppWidgetManagerImpl;
        friend struct std::default_delete< AppWidgetManager >;
-};
+}; //AppWidgetManager
 
 }} // Tizen::Shell
 #endif /* _FSHELL_APPWIDGET_MANAGER_H_ */

diff --git a/inc/FShellIAppWidgetPopupProviderFactory.h b/inc/FShellIAppWidgetPopupProviderFactory.h
index 72f7d2a..c69e9b8 100644 (file)
--- a/inc/FShellIAppWidgetPopupProviderFactory.h
+++ b/inc/FShellIAppWidgetPopupProviderFactory.h
@@ -94,4 +94,4 @@ protected:
 
 }} // Tizen::Shell
 
-#endif /* _IAPPWIDGET_POPUP_FACTORY_H_ */
+#endif /*  _FSHELL_IAPPWIDGET_POPUP_PROVIDER_FACTORY_H_ */

diff --git a/src/FShellAppWidgetFrame.cpp b/src/FShellAppWidgetFrame.cpp
index 601bb6a..0e10cff 100644 (file)
--- a/src/FShellAppWidgetFrame.cpp
+++ b/src/FShellAppWidgetFrame.cpp
@@ -45,6 +45,7 @@ result
 AppWidgetFrame::Construct(const FloatDimension& size)
 {
        SysTryReturnResult(NID_SHELL, _AppWidgetManagerImpl::HasFeature(), E_UNSUPPORTED_OPERATION, "This operation is not supported.");
+       SysTryReturnResult(NID_SHELL, size.width >= 0.0f && size.height >= 0.0f, E_INVALID_ARG, "Can't construct the AppWidgetFrame which size is less than zero.");
 
        SysAssertf(_pControlImpl == null, "Already constructed. Calling Construct() twice or more on a same instance is not allowed for this class.");
        unique_ptr<_AppWidgetFrameImpl> pImpl(_AppWidgetFrameImpl::CreateAppWidgetFrameImplN(*this, null, null));
@@ -63,6 +64,7 @@ result
 AppWidgetFrame::Construct(const Layout& layout, const FloatDimension& size)
 {
        SysTryReturnResult(NID_SHELL, _AppWidgetManagerImpl::HasFeature(), E_UNSUPPORTED_OPERATION, "This operation is not supported.");
+       SysTryReturnResult(NID_SHELL, size.width >= 0.0f && size.height >= 0.0f, E_INVALID_ARG, "Can't construct the AppWidgetFrame which size is less than zero.");
 
        SysAssertf(_pControlImpl == null, "Already constructed. Calling Construct() twice or more on a same instance is not allowed for this class.");
 

diff --git a/src/FShellAppWidgetPopup.cpp b/src/FShellAppWidgetPopup.cpp
index 8ae132e..7e3eb80 100644 (file)
--- a/src/FShellAppWidgetPopup.cpp
+++ b/src/FShellAppWidgetPopup.cpp
@@ -45,6 +45,7 @@ result
 AppWidgetPopup::Construct(const FloatDimension& size)
 {
        SysTryReturnResult(NID_SHELL, _AppWidgetManagerImpl::HasFeature(), E_UNSUPPORTED_OPERATION, "This operation is not supported.");
+       SysTryReturnResult(NID_SHELL, size.width >= 0.0f && size.height >= 0.0f, E_INVALID_ARG, "Can't construct the AppWidgetPopup which size is less than zero.");
 
        SysAssertf(_pControlImpl == null, "Already constructed. Calling Construct() twice or more on a same instance is not allowed for this class.");
 
@@ -64,6 +65,7 @@ result
 AppWidgetPopup::Construct(const Layout& layout, const FloatDimension& size)
 {
        SysTryReturnResult(NID_SHELL, _AppWidgetManagerImpl::HasFeature(), E_UNSUPPORTED_OPERATION, "This operation is not supported.");
+       SysTryReturnResult(NID_SHELL, size.width >= 0.0f && size.height >= 0.0f, E_INVALID_ARG, "Can't construct the AppWidgetPopup which size is less than zero.");
 
        SysAssertf(_pControlImpl == null, "Already constructed. Calling Construct() twice or more on a same instance is not allowed for this class.");
 
@@ -95,8 +97,7 @@ AppWidgetPopup::GetClientAreaCanvasN(void) const
        SysAssertf(pImpl != null, "Not yet constructed. Construct() should be called before use.");
 
        Canvas* pCanvas = pImpl->GetClientAreaCanvasN();
-       result r = GetLastResult();
-       SysTryReturn(NID_SHELL, pCanvas, null, r, "[%s] Propagating.", GetErrorMessage(r));
+       SysTryReturn(NID_SHELL, pCanvas, null, E_RESOURCE_UNAVAILABLE, "[E_RESOURCE_UNAVAILABLE] Propagating.");
 
        return pCanvas;
 }

diff --git a/src/FShell_AppWidgetManagerImpl.cpp b/src/FShell_AppWidgetManagerImpl.cpp
index 10963e3..3685b6a 100644 (file)
--- a/src/FShell_AppWidgetManagerImpl.cpp
+++ b/src/FShell_AppWidgetManagerImpl.cpp
@@ -152,7 +152,7 @@ _AppWidgetManagerImpl::GetDefaultAppWidgetProviderInfoN(const Tizen::App::Packag
        std::unique_ptr<char[]> pPackageId(_StringConverter::CopyToCharArrayN(packageId) );
        std::unique_ptr<char[]> pDefaultProviderId(livebox_service_pkgname(pPackageId.get()) );
        SysTryReturn(NID_SHELL, pDefaultProviderId.get(), null, E_SUCCESS, "Specified package(%ls) has no default provider.", packageId.GetPointer() );
-
+       
        String providerId(pDefaultProviderId.get());
        String appId;
        String providerName;

diff --git a/src/FShell_AppWidgetProviderInfoImpl.cpp b/src/FShell_AppWidgetProviderInfoImpl.cpp
index ecd7172..94e7a69 100644 (file)
--- a/src/FShell_AppWidgetProviderInfoImpl.cpp
+++ b/src/FShell_AppWidgetProviderInfoImpl.cpp
@@ -208,6 +208,7 @@ _AppWidgetProviderInfoImpl::GetSizeInfoListN() const
 AppWidgetProviderInfo*
 _AppWidgetProviderInfoImpl::GetAppWidgetProviderInfoN(const Tizen::App::AppId& appId, const Tizen::Base::String& providerName)
 {
+       SysTryReturn(NID_SHELL, !providerName.IsEmpty(), null, E_OBJ_NOT_FOUND, "The provider name is empty.");
        std::unique_ptr<char[]> pProviderId(_StringConverter::CopyToCharArrayN(_AppWidgetManagerImpl::MakeProviderName(appId, providerName)));
 
        bool isDefault = livebox_service_is_primary(pProviderId.get());

diff --git a/src/FShell_AppWidgetProviderManagerImpl.cpp b/src/FShell_AppWidgetProviderManagerImpl.cpp
index 01aed75..bc4c416 100644 (file)
--- a/src/FShell_AppWidgetProviderManagerImpl.cpp
+++ b/src/FShell_AppWidgetProviderManagerImpl.cpp
@@ -202,8 +202,8 @@ _AppWidgetProviderManagerImpl::IsPackagedWithTPK(const AppId& appId)
 result
 _AppWidgetProviderManagerImpl::RequestUpdate(const AppId& appId, const String& providerName, const String& argument)
 {
-
        SysLog(NID_SHELL, "Enter.");
+       SysTryReturnResult(NID_SHELL, _Aul::IsInstalled(appId) == true, E_APP_NOT_INSTALLED, "The application(%ls) is not installed.", appId.GetPointer());
 
        result r = CheckCertificate(Tizen::App::App::GetInstance()->GetAppId(), appId);
        SysTryReturn(NID_SHELL, !IsFailed(r), r, r, "[%s] VerifyCertification is failed.", GetErrorMessage(r));