projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
46e3370
)
iio: adc: ti-ads1100: fix error code in probe()
author
Dan Carpenter
<error27@gmail.com>
Thu, 23 Mar 2023 15:23:56 +0000
(18:23 +0300)
committer
Jonathan Cameron
<Jonathan.Cameron@huawei.com>
Mon, 10 Apr 2023 11:26:33 +0000
(12:26 +0100)
This code has a copy and paste bug so it accidentally returns
"PTR_ERR(data->reg_vdd)" which is a valid pointer cast to int. It
should return "ret" instead.
Fixes:
541880542f2b
("iio: adc: Add TI ADS1100 and ADS1000")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link:
https://lore.kernel.org/r/36fa2aeb-f392-4793-8b38-ae15514033c8@kili.mountain
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-ads1100.c
patch
|
blob
|
history
diff --git
a/drivers/iio/adc/ti-ads1100.c
b/drivers/iio/adc/ti-ads1100.c
index
6a478ef
..
6b5aebb
100644
(file)
--- a/
drivers/iio/adc/ti-ads1100.c
+++ b/
drivers/iio/adc/ti-ads1100.c
@@
-344,7
+344,7
@@
static int ads1100_probe(struct i2c_client *client)
ret = regulator_enable(data->reg_vdd);
if (ret < 0)
- return dev_err_probe(dev,
PTR_ERR(data->reg_vdd)
,
+ return dev_err_probe(dev,
ret
,
"Failed to enable vdd regulator\n");
ret = devm_add_action_or_reset(dev, ads1100_reg_disable, data->reg_vdd);