playbin2: do not try to deactivate an inactive group
authorVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Wed, 18 Jan 2012 14:58:08 +0000 (14:58 +0000)
committerVincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Mon, 23 Jan 2012 11:56:50 +0000 (11:56 +0000)
A group may have failed to activate due to an error (for instance,
having set the URI to a non existent location in about-to-finish).

https://bugzilla.gnome.org/show_bug.cgi?id=666395

gst/playback/gstplaybin2.c

index f8ccb51..e01ff6c 100644 (file)
@@ -3846,7 +3846,7 @@ save_current_group (GstPlayBin * playbin)
   /* see if there is a current group */
   GST_PLAY_BIN_LOCK (playbin);
   curr_group = playbin->curr_group;
-  if (curr_group && curr_group->valid) {
+  if (curr_group && curr_group->valid && curr_group->active) {
     /* unlink our pads with the sink */
     deactivate_group (playbin, curr_group);
   }